Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update running-pinot-in-docker.md to include minion config #397

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

Update running-pinot-in-docker.md to include minion config #397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e844f
Update running-pinot-in-docker.md to include minion config
vipulchandraker Nov 27, 2024
57db84a
Update running-pinot-in-docker.md
vipulchandraker Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions basics/getting-started/running-pinot-in-docker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,16 @@ services:
retries: 5
start_period: 10s

pinot-minion:
image: ${PINOT_IMAGE:-apachepinot/pinot:1.2.0}
command: "StartMinion -zkAddress zookeeper-houseprices:2181"
Copy link
Contributor

@NihalJain NihalJain Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do you mean pinot-zookeeper:2181? Is this docker compose file tested?
  2. Could we add ports?
  3. Can you also update relevant services which start up i.e. docker container ls output?
  4. Also consider adding how to start minion via docker run in the section above docker compose section?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NihalJain I have made all the suggested changes and tested the docker compose file. Please review

restart: unless-stopped
container_name: "pinot-minion"
depends_on:
- pinot-broker
networks:
- pinot-demo

networks:
pinot-demo:
name: pinot-demo
Expand Down