Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sjoshi/push manager patch #29

Closed
wants to merge 1 commit into from

Conversation

sjoshi6
Copy link

@sjoshi6 sjoshi6 commented Oct 31, 2024

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sjoshi6 sjoshi6 changed the base branch from ray-2.10.0+pinterest4 to pinterest/main-2.10.0 October 31, 2024 18:47
@sjoshi6 sjoshi6 closed this Oct 31, 2024
@sjoshi6 sjoshi6 deleted the sjoshi/push_manager_patch branch October 31, 2024 18:51
@sjoshi6 sjoshi6 restored the sjoshi/push_manager_patch branch October 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant