Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sjoshi/push manager patch #29

Closed
wants to merge 1 commit into from
Closed

Sjoshi/push manager patch #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/ray/object_manager/push_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,19 @@ void PushManager::OnChunkComplete(const NodeID &dest_id, const ObjectID &obj_id)

void PushManager::ScheduleRemainingPushes() {
bool keep_looping = true;
// Loop over all active pushes for approximate round-robin prioritization.
// TODO(ekl) this isn't the best implementation of round robin, we should
// consider tracking the number of chunks active per-push and balancing those.

// Keep looping while we have capacity and are making progress
while (chunks_in_flight_ < max_chunks_in_flight_ && keep_looping) {
// Loop over each active push and try to send another chunk.
// Loop over the list of active pushes and try to send another chunk
auto it = push_requests_with_chunks_to_send_.begin();
keep_looping = false;
// Walk through each push request in the list
while (it != push_requests_with_chunks_to_send_.end() &&
chunks_in_flight_ < max_chunks_in_flight_) {
auto push_id = it->first;
auto &info = it->second;
if (info->SendOneChunk()) {
while (chunks_in_flight_ < max_chunks_in_flight_ && info->SendOneChunk()) {
// finish as many chunks of the head request as possible
chunks_in_flight_ += 1;
keep_looping = true;
RAY_LOG(DEBUG) << "Sending chunk " << info->next_chunk_id << " of "
Expand All @@ -83,6 +84,7 @@ void PushManager::ScheduleRemainingPushes() {
<< " / " << max_chunks_in_flight_
<< " max, remaining chunks: " << NumChunksRemaining();
}
// If all chunks are sent for the current request, remove it from the list
if (info->NoChunksToSend()) {
it = push_requests_with_chunks_to_send_.erase(it);
} else {
Expand Down
Loading