Sound Cleanup #5959
Sound Cleanup #5959
Conversation
|
I have my sound back end working reasonably well, so I went ahead and did the crossfade consolidation. |
|
Will review this soon - been busy with some other concerns. What I'm reading so far seems to be moving in the right direction; I definitely appreciate moving the "fiddly details" of audio mixing entirely behind a higher-level API. Do note that any proposed audio backend replacement would necessarily need to be able to handle 3d directional audio, so I have my eyes on something along the lines of soloud or an equivalent middleware - my understanding of OpenAL is that it is a somewhat heavyweight dependency. |
|
My immediate goal is to make switching out the backend easier so I can exercise my own audio library. After that I probably won't touch Sound again and I'm not going to advocate for any particular backend. I did just build SoLoud to compare the shared library size. It weighs in at 751kB vs. the 1063kB for OpenAL that comes with my distro. SoLoud can use OpenAL as a backend, but it seems a bit dated as there is none for PulseAudio. |
| } | ||
|
|
||
| return songs; | ||
| return GetMusicFiles(); |
There was a problem hiding this comment.
This is conceptually messy, but in the interest of not increasing the scope of this PR I'll consider this "not worse than before"; the compiler is very likely to perform RVO here, so it's not a significant performance issue.
- Replace GetSamples() with GetMusicFiles().
MusicEvent differs from Event by only one line and is replaced by an Event::PlayMusic method.
This cleans up lots of VolumeAnimate/SetOp calls and allows for future optimizations (such as eliminating one mutex lock operation).
Consolidating all the stop/play/fade operations will allow the number of mutex locks to be reduced in the future.
WickedSmoke
force-pushed
the
sound_cleanup
branch
from
99990ad
to
678d46e
Compare
These commits cleanup the Sound and SoundMusic interfaces to allow plugging in an alternative backend (e.g. OpenAL) simply by switching out sound/Sound.cpp.
This pull request does not address the make file changes required to actually do this. However, a working proof of concept can be found on my repository.
Future work could include: