Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound Cleanup #5959

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Sound Cleanup #5959

merged 6 commits into from
Nov 23, 2024
+108 −144

Commits on Nov 22, 2024

  1. Remove SDL dependencies from Sound interface.

    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    347db3f View commit details
    Browse the repository at this point in the history

  2. Make Sample struct private within Sound module. 

     - Replace GetSamples() with GetMusicFiles().
    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    206df18 View commit details
    Browse the repository at this point in the history

  3. Sound: Make eventid private. Remove MusicEvent. 

    MusicEvent differs from Event by only one line and is replaced by an
Event::PlayMusic method.
    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    33044de View commit details
    Browse the repository at this point in the history

  4. Sound: Add Event::FadeOut(). 

    This cleans up lots of VolumeAnimate/SetOp calls and allows for future
optimizations (such as eliminating one mutex lock operation).
    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d265287 View commit details
    Browse the repository at this point in the history

  5. Sound.cpp: Remove unused internal SetOp (duplicates Event::SetOp).

    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    42b143a View commit details
    Browse the repository at this point in the history

  6. Change Sound::Event::PlayMusic to handle crossfading. 

    Consolidating all the stop/play/fade operations will allow the number of
mutex locks to be reduced in the future.
    @WickedSmoke
    WickedSmoke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    678d46e View commit details
    Browse the repository at this point in the history