Add input params for OpenAI, Anthropic, Together AI LLMs #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Sep 20, 2024
src/pipecat/services/anthropic.py
Outdated
| @@ -82,12 +87,16 @@ def __init__( | |||
| model: str = "claude-3-5-sonnet-20240620", | |||
| max_tokens: int = 4096, | |||
| enable_prompt_caching_beta: bool = False, | |||
There was a problem hiding this comment.
I believe we should add max_tokens and enable_prompt_caching_beta to InputParams as well. It's a breaking change, but we are breaking a few things in this next release, so it should be fine. In the emotion Cartesia PR we are also breaking it.
There was a problem hiding this comment.
I held off because this was breaking, but I'll make the change now.
aconchillo
reviewed
Sep 20, 2024
|
|
||
| def __init__( | ||
| self, | ||
| *, | ||
| api_key: str, | ||
| model: str = "meta-llama/Meta-Llama-3.1-8B-Instruct-Turbo", | ||
| max_tokens: int = 4096, | ||
| params: InputParams = InputParams(), |
There was a problem hiding this comment.
we should probably add max_tokens inside InputParams here as well.
|
Looks great! Just a couple of comments. |
markbackman
force-pushed
the
mb/llm-input-params
branch
3 times, most recently
from
fde2bbb to
99eb2cd
Compare
aconchillo
reviewed
Sep 20, 2024
src/pipecat/services/together.py
Outdated
| self._temperature = temperature | ||
|
|
||
| async def set_top_k(self, top_k: float): | ||
| logger.debug(f"Switching LLM top_p to: [{top_k}]") |
aconchillo
reviewed
Sep 20, 2024
| *, | ||
| model: str = "gpt-4o", | ||
| params: BaseOpenAILLMService.InputParams = BaseOpenAILLMService.InputParams(), | ||
| **kwargs): |
aconchillo
approved these changes
Sep 20, 2024
markbackman
force-pushed
the
mb/llm-input-params
branch
from
99eb2cd to
f3fd312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opted to keep the inputs to the most common options. With this structure in place, it'll be easy to expand as needed.
Also, I added a Together AI example to make testing with Together AI easier.