feat: Fix combineSkeletons #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a model that uses the same skinIndex accessor but not the same skinWeight accessors between meshes This commit updates the implementation of attributeUsedIndexSetMap to use both skinIndex and skinWeight accesstors The same skinIndex accessor could also be used between different bone sets Clone the bone set if the skinIndex accessor is the same but the bone set is different
0b5vr
commented
Jan 14, 2025
| // Collect skin index attributes | ||
| // skinIndex attribute might be shared among different bone sets | ||
| // If there are multiple bone sets that share the same skinIndex attribute, clone the attribute | ||
| const skinIndexNewSkinIndexBonesMapMap = new Map< |
There was a problem hiding this comment.
If there is a skin index accessor that is used with two or more different bone sets, you can check by seeing inside the skinIndexNewSkinIndexBonesMapMap
ke456-png
requested changes
Jan 15, 2025
The continue statement was not working as intended I also forgot to set the new attribute when we found an already registered skin index attribute I had to change eslint `@typescript-eslint/naming-convention` rule in order to use `_` for parameter name See: https://typescript-eslint.io/rules/naming-convention/
0b5vr
force-pushed
the
fix-combine-skeletons
branch
from
771f39b to
902e6d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
combineSkeletons.There is a model that uses the same skinIndex accessor but not the same skinWeight accessors between meshes.
This PR updates the implementation of attributeUsedIndexSetMap to use both skinIndex and skinWeight accesstors.
The same skinIndex accessor could also be used between different bone sets.
Clone the bone set if the skinIndex accessor is the same but the bone set is different.