-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packing matmul dims equal to block size #961
Conversation
No impact on benchmarks. |
Just to check: the only change is to allow the tiling validation to succeed in case |
Yes, previously the default was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure if from the previous PR, not sure why it only triggered here.
@KavithaTipturMadhu please have a look.
Relaxes matmul packing blocked dimensions validation to allow packing when `matmul dims >= block factor`.
3a5e51e
to
62b0e55
Compare
The failing test was unstable across runs possibly due to temporary file names being assigned to environment variables. We need to think of a work-around for this, till then I've deleted it from tpp-mlir repo. |
Relaxes matmul packing blocked dimensions validation to allow packing when
matmul dims >= block factor
.