Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packing matmul dims equal to block size #961

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

adam-smnk
Copy link
Collaborator

Relaxes matmul packing blocked dimensions validation to allow packing when matmul dims >= block factor.

@adam-smnk adam-smnk added the benchmark Triggers benchmark jobs label Sep 4, 2024
@adam-smnk adam-smnk changed the title Allow packing matmum dims equal to block size Allow packing matmul dims equal to block size Sep 4, 2024
@adam-smnk
Copy link
Collaborator Author

No impact on benchmarks.

@rolfmorel
Copy link
Contributor

Just to check: the only change is to allow the tiling validation to succeed in case matmul dims == block factor, right?

@adam-smnk
Copy link
Collaborator Author

Just to check: the only change is to allow the tiling validation to succeed in case matmul dims == block factor, right?

Yes, previously the default was dim / factor >= 2.

Copy link
Contributor

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure if from the previous PR, not sure why it only triggered here.

@KavithaTipturMadhu please have a look.

Relaxes matmul packing blocked dimensions validation to allow packing
when `matmul dims >= block factor`.
@adam-smnk adam-smnk force-pushed the relax-packing-validation branch from 3a5e51e to 62b0e55 Compare September 4, 2024 14:44
@KavithaTipturMadhu
Copy link
Contributor

The failure if from the previous PR, not sure why it only triggered here.

@KavithaTipturMadhu please have a look.

The failing test was unstable across runs possibly due to temporary file names being assigned to environment variables. We need to think of a work-around for this, till then I've deleted it from tpp-mlir repo.

@adam-smnk adam-smnk merged commit 67f9830 into plaidml:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Triggers benchmark jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants