Update goal in segment #5027
Open
Update goal in segment #5027
+101
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
reviewed
Jan 29, 2025
apata
reviewed
Jan 29, 2025
test/plausible/goals_test.exs
Outdated
Comment on lines
142
to
148
| assert updated_segment.segment_data == %{ | ||
| "filters" => [ | ||
| ["is", "event:page", ["/blog"]], | ||
| ["is", "event:goal", ["Signup from nav", "SIGNUP"]], | ||
| ["is", "event:props:variant", ["A"]] | ||
| ] | ||
| } |
There was a problem hiding this comment.
issue: Noticed that we also override segment updated_at.
If that's intentional, it would be good to assert it here as well, with something like segment.updated_at < updated_segment.updated_at.
Alternatively, we may want to not override updated_at on these automatic updates. May be confusing when the message in the UI (Last updated at <stamp> by <name>) doesn't match with their usual online time.
Or we could also just rephrase it in the UI: Last updated at <stamp>, belongs to <name> or similar.
apata
reviewed
Jan 29, 2025
apata
reviewed
Jan 29, 2025
apata
reviewed
Jan 29, 2025
aerosol
requested changes
Jan 30, 2025
| %Plausible.Goal{} = stale_goal, | ||
| %Plausible.Goal{} = updated_goal | ||
| ) do | ||
| goal_filter_regex = |
There was a problem hiding this comment.
This requires inline commentary so the reader won't have to wonder what are we trying to achieve here
apata
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a goal's display name is updated, this PR makes it so the segments containing that goal are also updated accordingly