Update goal in segment

lib/plausible/goals/goals.ex

@@ -56,16 +56,20 @@ defmodule Plausible.Goals do
           {:ok, Goal.t()} | {:error, Ecto.Changeset.t()} | {:error, :upgrade_required}
   def update(goal, params) do
     changeset = Goal.changeset(goal, params)
-    site = Repo.preload(goal, :site).site
 
-    with :ok <- maybe_check_feature_access(site, changeset),
-         {:ok, goal} <- Repo.update(changeset) do
-      on_ee do
-        {:ok, Repo.preload(goal, :funnels)}
-      else
-        {:ok, goal}
+    Repo.transaction(fn ->
+      site = Repo.preload(goal, :site).site
+
+      with :ok <- maybe_check_feature_access(site, changeset),
+           {:ok, updated_goal} <- Repo.update(changeset),
+           :ok <- Plausible.Segments.update_goal_in_segments(site, goal, updated_goal) do
+        on_ee do
+          {:ok, Repo.preload(updated_goal, :funnels)}
+        else
+          {:ok, updated_goal}
+        end
       end
-    end
+    end)
   end
 
   def find_or_create(

lib/plausible/segments/segments.ex

@@ -131,6 +131,50 @@ defmodule Plausible.Segments do
     end
   end
 
+  def update_goal_in_segments(
+        %Plausible.Site{} = site,
+        %Plausible.Goal{} = stale_goal,
+        %Plausible.Goal{} = updated_goal
+      ) do
+    goal_filter_regex =
+      ~s(.*?\\["is",\s*"event:goal",\s*\\[.*?"#{Regex.escape(stale_goal.display_name)}".*?\\]\\].*?)
+
+    IO.inspect(stale_goal)
+
+    segments_to_update =
+      from(
+        s in Segment,
+        where: s.site_id == ^site.id,
+        where: fragment("?['filters']::text ~ ?", s.segment_data, ^goal_filter_regex)
+      )
+
+    stale_goal_name = stale_goal.display_name
+
+    for segment <- Repo.all(segments_to_update) do
+      updated_filters =
+        Plausible.Stats.Filters.transform_filters(segment.segment_data["filters"], fn
+          ["is", "event:goal", clauses] ->
+            new_clauses =
+              Enum.map(clauses, fn
+                ^stale_goal_name -> updated_goal.display_name
+                clause -> clause
+              end)
+
+            [["is", "event:goal", new_clauses]]
+
+          _ ->
+            nil
+        end)
+
+      updated_segment_data = Map.put(segment.segment_data, "filters", updated_filters)
+
+      Segment.changeset(segment, %{segment_data: updated_segment_data})
+      |> Repo.update!()
+    end
+
+    :ok
+  end
+
   def delete_one(user_id, %Plausible.Site{} = site, site_role, segment_id) do
     with {:ok, segment} <- get_one(user_id, site, site_role, segment_id) do
       cond do

test/plausible/goals_test.exs

@@ -108,7 +108,7 @@
     assert [currency: {"is invalid", _}] = changeset.errors
   end
 
   test "update/2 updates a goal" do
     site = new_site()
     {:ok, goal1} = Goals.create(site, %{"page_path" => "/foo bar "})
     {:ok, goal2} = Goals.update(goal1, %{"page_path" => "/", "display_name" => "Homepage"})
@@ -117,6 +117,37 @@
     assert goal2.display_name == "Homepage"
   end
 
+  test "update/2 also updates any segments the goal is a part of" do
+    user = new_user()
+    site = new_site(owner: user)
+    {:ok, goal1} = Goals.create(site, %{"event_name" => "Signup"})
+    {:ok, _goal2} = Goals.create(site, %{"event_name" => "Signup from nav"})
+
+    {:ok, segment} =
+      Plausible.Segments.insert_one(user.id, site, :editor, %{
+        "type" => "site",
+        "segment_data" => %{
+          "filters" => [
+            ["is", "event:page", ["/blog"]],
+            ["is", "event:goal", ["Signup from nav", "Signup"]],
+            ["is", "event:props:variant", ["A"]]
+          ]
+        },
+        "name" => "Segment name"
+      })
+
+    Goals.update(goal1, %{"display_name" => "SIGNUP"})
+    updated_segment = Repo.reload!(segment)
+
+    assert updated_segment.segment_data == %{
+             "filters" => [
+               ["is", "event:page", ["/blog"]],
+               ["is", "event:goal", ["Signup from nav", "SIGNUP"]],
+               ["is", "event:props:variant", ["A"]]
+             ]
+           }
+  end
+
   @tag :ee_only
   test "list_revenue_goals/1 lists event_names and currencies for each revenue goal" do
     site = new_site()