WIP: Video block new embed #6359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@sneridagh should this new component be moved to the volto components package or shall it stay in there core package? |
|
@jackahl LGTM, however, I'd put the component as general available component, in |
stevepiercy
requested changes
Oct 9, 2024
| @@ -3703,6 +3703,11 @@ msgstr "" | |||
| msgid "The value does not match the pattern {pattern}" | |||
| msgstr "" | |||
|
|
|||
| #. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty." | |||
There was a problem hiding this comment.
There was a bad copy paste throughout, so I will only make a suggestion on this one instance which should be applied to all instances.
Suggested change
| #. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty." | |
| #. Default: "The video's title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the video is already sufficiently titled by a headline above, then leave this field empty." |
Co-authored-by: Steve Piercy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the semantic ui embed component with a custom one, to allow for more flexibility especially in regards to accessibility. This does mainly address issues raised in #5731.