Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Video block new embed #6359

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/vite-ssr/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Plone on Vite with SSR mode

This is a proof of concept of a [Vite](https://vite.dev/) build, using `@plone/client` and `@plone/components` libraries.
This is a proof of concept of a [Vite](https://vite.dev) build, using `@plone/client` and `@plone/components` libraries.

This is intended to serve as both a playground for the development of both packages and as a demo of Plone using Vite built with server side rendering (SSR).

It also uses [TanStack Router](https://tanstack.com/router/latest/docs/framework/react/overview) for its routing library.
1 change: 1 addition & 0 deletions apps/vite/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Plone on Vite

This is a proof of concept of a [Vite](https://vite.dev/) build, using `@plone/client` and `@plone/components` libraries.

This is intended to serve as both a playground for the development of both packages and as a demo of Plone using Vite.

It also uses [TanStack Router](https://tanstack.com/router/latest/docs/framework/react/overview) for its routing library.
6 changes: 6 additions & 0 deletions packages/volto/locales/ca/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3707,6 +3707,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3807,6 +3812,7 @@ msgstr "Hora"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/de/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3706,6 +3706,11 @@ msgstr "Die Seitenkonfiguration ist veraltet und muss aktualisiert werden."
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3806,6 +3811,7 @@ msgstr "Zeit"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/en/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3701,6 +3701,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3801,6 +3806,7 @@ msgstr ""
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/es/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3708,6 +3708,11 @@ msgstr "La configuración del sitio está anticuada y debe ser actualizada."
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3808,6 +3813,7 @@ msgstr "Hora"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/eu/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3708,6 +3708,11 @@ msgstr "Atariaren konfigurazioa zaharkituta dago eta eguneratu egin behar da."
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3808,6 +3813,7 @@ msgstr "Ordua"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/fi/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3706,6 +3706,11 @@ msgstr "Sivuston konfiguraatio on vanhentunut ja se pitää päivittää."
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3806,6 +3811,7 @@ msgstr "Aika"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/fr/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3708,6 +3708,11 @@ msgstr "La configuration du site nécessite une mise à niveau."
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3808,6 +3813,7 @@ msgstr "Temps"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/hi/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3701,6 +3701,11 @@ msgstr "साइट कॉन्फ़िगरेशन पुरानी ह
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3801,6 +3806,7 @@ msgstr "समय"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/it/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3701,6 +3701,11 @@ msgstr "La configurazione del sito è obsoleta e deve essere aggiornata."
msgid "The value does not match the pattern {pattern}"
msgstr "I valori non corrispondono al pattern {pattern}"

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3801,6 +3806,7 @@ msgstr "Ora"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/ja/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3706,6 +3706,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3806,6 +3811,7 @@ msgstr "時刻"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/nl/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3705,6 +3705,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3805,6 +3810,7 @@ msgstr ""
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/pt/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3706,6 +3706,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3806,6 +3811,7 @@ msgstr ""
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/pt_BR/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3707,6 +3707,11 @@ msgstr "A configuração do site está desatualizada e precisa ser atualizada."
msgid "The value does not match the pattern {pattern}"
msgstr "O valor não corresponde ao padrão {pattern}"

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3807,6 +3812,7 @@ msgstr "Hora"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/ro/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3701,6 +3701,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3801,6 +3806,7 @@ msgstr "Oră"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
8 changes: 7 additions & 1 deletion packages/volto/locales/volto.pot
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
msgid ""
msgstr ""
"Project-Id-Version: Plone\n"
"POT-Creation-Date: 2024-09-19T10:10:37.548Z\n"
"POT-Creation-Date: 2024-10-01T08:57:25.996Z\n"
"Last-Translator: Plone i18n <[email protected]>\n"
"Language-Team: Plone i18n <[email protected]>\n"
"Content-Type: text/plain; charset=utf-8\n"
Expand Down Expand Up @@ -3703,6 +3703,11 @@ msgstr ""
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bad copy paste throughout, so I will only make a suggestion on this one instance which should be applied to all instances.

Suggested change
#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#. Default: "The video's title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the video is already sufficiently titled by a headline above, then leave this field empty."

#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3803,6 +3808,7 @@ msgstr ""
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
6 changes: 6 additions & 0 deletions packages/volto/locales/zh_CN/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -3707,6 +3707,11 @@ msgstr "网站配置已过时,需要升级。"
msgid "The value does not match the pattern {pattern}"
msgstr ""

#. Default: "The videos title is not displayed, but only used for accessibility reasons to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
#: components/manage/Blocks/Video/schema
msgid "The videos title is not displayed, but only used for accessibility reason to identify the video for screen reader users. If the Video is already sufficiently titled by a headline above, please leave this field empty."
msgstr ""

#. Default: "The working copy was discarded"
#: components/manage/Toolbar/More
msgid "The working copy was discarded"
Expand Down Expand Up @@ -3807,6 +3812,7 @@ msgstr "时间"
#. Default: "Title"
#: components/manage/Blocks/Teaser/schema
#: components/manage/Blocks/ToC/Schema
#: components/manage/Blocks/Video/schema
#: components/manage/Contents/Contents
#: components/manage/Contents/ContentsRenameModal
#: components/manage/Controlpanels/ContentTypes
Expand Down
1 change: 1 addition & 0 deletions packages/volto/news/6359.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
create new video embed component for usage in video block helping to fix a11y issues with the semantic ui one @jackahl
jackahl marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions packages/volto/src/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export { default as Image } from '@plone/volto/components/theme/Image/Image';
export { default as ConditionalLink } from '@plone/volto/components/manage/ConditionalLink/ConditionalLink';
export { default as UniversalLink } from '@plone/volto/components/manage/UniversalLink/UniversalLink';
export { default as LinkMore } from '@plone/volto/components/manage/LinkMore/LinkMore';
export { default as VideoEmbed } from '@plone/volto/components/theme/VideoEmbed/VideoEmbed';

// Lazy load them, since we want them and its deps to be in its own chunk
export { default as ContactForm } from '@plone/volto/components/theme/ContactForm/ContactForm';
Expand Down
Loading
Loading