Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-contract): <- emit metadata event in that #8

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

gskapka
Copy link
Contributor

@gskapka gskapka commented Feb 8, 2024

This allows cores to read this event and pass through the origin transaction details instead of them being replaced by those pertaining to the interim chain.

@gskapka gskapka self-assigned this Feb 8, 2024
@gskapka gskapka changed the title Emit metadata event feat(router-contract): <- emit metadata event in that Feb 8, 2024
@gskapka gskapka requested a review from oliviera9 February 8, 2024 14:25
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments. LGTM overall.

contracts/PTokensRouter.sol Outdated Show resolved Hide resolved
contracts/PTokensRouter.sol Outdated Show resolved Hide resolved
test/ptokens-router.test.js Show resolved Hide resolved
@gskapka gskapka force-pushed the emit-metadata-event branch from 8516f36 to 2904726 Compare February 13, 2024 16:57
@gskapka gskapka requested a review from oliviera9 February 13, 2024 16:59
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/ptokens-router.test.js Show resolved Hide resolved
@gskapka gskapka merged commit 76ea65d into master Feb 13, 2024
1 check passed
@gskapka gskapka deleted the emit-metadata-event branch February 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants