EE-2404: EE-1120: Chore/refactor edge #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s _and_ --help Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
… a feature? Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
…e.ID Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
chore/refactor-edge
branch
from
a9b048c
to
be12a1c
Compare
Signed-off-by: Sven Dowideit <[email protected]>
chiptus
reviewed
Jan 26, 2022
chiptus
reviewed
Jan 26, 2022
chiptus
reviewed
Jan 26, 2022
chiptus
reviewed
Jan 26, 2022
chiptus
reviewed
Jan 26, 2022
SvenDowideit
changed the title
SvenDowideit
changed the title
|
I've think I've addressed most of the comments here, keen for another review @SvenDowideit @cheloRydel @andres-portainer @chiptus |
|
yup, feels like its going in good directions - LGTM |
|
A last one for you @SvenDowideit , the last commit address the comment we talked about in #230 (review) |
|
yup, more LGTM - I finally found a less bad place to implement the async stuff, so i'll make a PR today for you all - and you'll see i needed to do something similar |
chiptus
suggested changes
Feb 17, 2022
andres-portainer
approved these changes
Feb 17, 2022
cheloRydel
reviewed
Feb 17, 2022
andres-portainer
approved these changes
Feb 17, 2022
Merged
sbusso
pushed a commit
that referenced
this pull request
Feb 23, 2022
* EE-2404: EE-1120: feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help (#228) * feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help Signed-off-by: Sven Dowideit <[email protected]> * clean out unused env var names Signed-off-by: Sven Dowideit <[email protected]> * use the ENV text from the README Signed-off-by: Sven Dowideit <[email protected]> * HostManagementEnabled was hardcoded to true - I presume this was once a feature? Signed-off-by: Sven Dowideit <[email protected]> * do we need to store a copy of a bool we have access to? Signed-off-by: Sven Dowideit <[email protected]> * add the LogLevels to the flag options Signed-off-by: Sven Dowideit <[email protected]> * Don't try over-writing the existing /data/agent_edge_key - its 0444 Signed-off-by: Sven Dowideit <[email protected]> * feat(edge): rollback key retrieval changes * refactor(edge): remove comment * feat(main): rollback changes to ip detection * refactor(options): remove unused options * refactor(options): remove comment Co-authored-by: deviantony <[email protected]> * feat(options): cli flag consistency between server/agent (#240) * EE-2404: EE-1120: Chore/refactor edge (#229) * feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help Signed-off-by: Sven Dowideit <[email protected]> * clean out unused env var names Signed-off-by: Sven Dowideit <[email protected]> * use the ENV text from the README Signed-off-by: Sven Dowideit <[email protected]> * HostManagementEnabled was hardcoded to true - I presume this was once a feature? Signed-off-by: Sven Dowideit <[email protected]> * do we need to store a copy of a bool we have access to? Signed-off-by: Sven Dowideit <[email protected]> * add the LogLevels to the flag options Signed-off-by: Sven Dowideit <[email protected]> * Don't try over-writing the existing /data/agent_edge_key - its 0444 Signed-off-by: Sven Dowideit <[email protected]> * EdgeKey retreival code should be with the other EdgeKey code Signed-off-by: Sven Dowideit <[email protected]> * PROPOSAL: don't create an edgeManager if we're not in Edge mode Signed-off-by: Sven Dowideit <[email protected]> * add todo Signed-off-by: Sven Dowideit <[email protected]> * JUST git mv internal/edge/ to edge/ Signed-off-by: Sven Dowideit <[email protected]> * git mv the scheduler code from filesystem/ to edge/scheduler/ Signed-off-by: Sven Dowideit <[email protected]> * git mv edge/logs.go edge/scheduler/logs.go - jobID in logs == schedule.ID Signed-off-by: Sven Dowideit <[email protected]> * git mv edge/stack.go edge/stack/stack.go Signed-off-by: Sven Dowideit <[email protected]> * feat(edge): rollback key retrieval changes * refactor(edge): remove comment * feat(main): rollback changes to ip detection * refactor(options): remove unused options * refactor(options): remove comment * refactor(http): update parameters * refactor(edge): refactor of the edge package * refactor(edge): refactor of the edge package * refactor(edge): import refactor * refactor(edge): refactor of the edge module * refactor(edge): refactor imports * refactor(http): do not store pointer to EdgeManager in Handler * refactor(edge): refactor edge tunnel capability mgmt * refactor(edge): rename parameter * refactor(main): update Edge condition check * refactor(http): review Edge mode server's handler enhancement Co-authored-by: deviantony <[email protected]> * refactor(edge): remove comment * fix(edge): fix mod of stack file from 644 to 0644 * refactor(edge): move http/client to edge/client * refactor(edge): move edge server from http package to edge/http * chore(agent): clean up the code EE-2559 (#251) Co-authored-by: Sven Dowideit <[email protected]> Co-authored-by: andres-portainer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://portainer.atlassian.net/browse/EE-2404
https://portainer.atlassian.net/browse/EE-1120
BASED on #228 - which should be merged first
(ignore the first 7 commits)
My plan for this is to setup to the code to make Async edge and mTLS make more sense for someone that is used to the webUI