V2 SDK readme에 ESM 설명 복붙 & V2 API Secret 발급 안내에 access token 관련 내용 제거 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
혹시 요거 참고해서 컴포넌트화 가능하실까요? 👀 |
finalchild
force-pushed
the
update-outdated-20240314
branch
from
7e71d76 to
01ef9f3
Compare
finalchild
force-pushed
the
update-outdated-20240314
branch
from
01ef9f3 to
20069c4
Compare
|
|
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
20069c4 to
b34fda4
Compare
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
b34fda4 to
543a53a
Compare
|
@XiNiHa @sso-ashley 이 PR도 이제 Ready 되었습니다 |
|
저 지금 메인 포스푸시하려고 리베이스중이라서... 그거 끝나고 봐볼게요 |
sso-ashley
reviewed
Mar 25, 2024
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
33845e3 to
4d581e8
Compare
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
4d581e8 to
09db180
Compare
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
09db180 to
35934df
Compare
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
35934df to
e6d617d
Compare
sso-ashley
reviewed
Mar 26, 2024
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
e6d617d to
2978d70
Compare
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
2978d70 to
29837bc
Compare
sso-ashley
approved these changes
Mar 26, 2024
XiNiHa
reviewed
Mar 26, 2024
| @@ -129,35 +69,34 @@ const response = await PortOne.requestPayment({ | |||
|
|
|||
| if (response.code != null) { | |||
| // 오류 발생 | |||
| return alert(response.message); | |||
| alert(response.message); | |||
| } | |||
There was a problem hiding this comment.
이거 return 안 하면 아래 fetch 실행되는 모양이 될 것 같은데.... 아마 파싱 에러 때문이었을 것 같은데 function requestPayment(){...}로 코드 감싸면 어떨까요?
LimJiGyu
force-pushed
the
update-outdated-20240314
branch
from
a795bdf to
8ebc2c9
Compare
XiNiHa
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
저번에 V2 인증결제 설명 다시 쓰면서 SDK 가져오는 설명을 잘 썼는데 SDK readme 페이지에 같은 내용이 있지만 반영이 안 되어 있어서 복붙합니다.
V2 API Secret으로 직접 API 호출이 가능해서 access token 발급이 더 이상 필수가 아닌데 안내문에 적혀 있는 경우가 있어 API 페이지로 링크해서 거기서 인증 방법 설명을 읽을 수 있게 합니다.