Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Virgin Mobile URL (complete fix now) #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pattonj
Copy link

@pattonj pattonj commented Feb 18, 2013

I updated the virgin mobile URL. It required the ww2 instead of ww1.
(This is also true if logging in via a web broswer).

While running in the emulator it was not able to correctly pull the
charge date nor did it show the black line in the pie graph. I don't
know if this was somethign with my emulator, or
something that will need
fixed. (see update below)

I updated the virgin mobile URL. It required the ww2 instead of ww1.
(This is also true if logging in via a web broswer).

While running in the emulator it was not able to correctly pull the
charge date nor did it show the black line in the pie graph. I don't
know if this was somethign with my emulator, or something that will need
fixed.
@pattonj
Copy link
Author

pattonj commented Feb 18, 2013

After testing it, if the app still has the problems mentioned I may work on fixing that as part of a class project. I'll have to wait and see though.

@jozuman
Copy link

jozuman commented Feb 25, 2013

i can confirm that the updated url does work at least better than the previous url though it looks like it fails to pull the charged on date. regardless, this change should be accepted and put onto the play store.

@pattonj
Copy link
Author

pattonj commented Feb 25, 2013

When changing the scraper to "You will be charged on" instead of date due, it returns Mo/M/04.

I messed around with the scraper code and told it to import the date from a different location in the page, which returns (displays on screen) Mon Mar 04 00:00:00 CST 2013 . For some reason the page is either not returning the date in the style as shows in the desktop version of the HTML, or the program is converting it. I guess I'll have to keep reading to figure it out.

If I hard code the proper date into the return, it shows the pie chart properly, so at least that works.

@pattonj
Copy link
Author

pattonj commented Apr 12, 2013

See the pull request by @graboszczak for a partial fix (my partial update). #37

Then I made a small edit to the websiteScraper to match the referenceScraper.
It fully works now!
Please update it in the play store.

Jacob Patton added 2 commits April 12, 2013 14:55
As to allow a partial fix.
The app is now fully working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants