Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scrapers to be in sync with website #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

graboszczak
Copy link

I fixed scrapers so they are in sync with recent VM website changes.

I tested it on my machine / my account only so please have a look if it makes sense.

HTML changed on the website so we need to search for different pattern
URL changed.
Also in order to get correct date format we need to pass correct encoding.
@pattonj
Copy link

pattonj commented Apr 12, 2013

The logging works, but I could not get it to show the due/charge date to work. When it does the scrape it pulls in the actual date instead of in the format "1/2/3". Below is the log of when my phone scraped.

(I don't know how to post it as code without having it convert the html).

Pay Now for Next Month's Plan ($35.00 +tax due on Sat May 04 00:00:00 CDT 2013)

  • Next Month's charge

    $35.00

  • Current Balance

    $0.00

  • You will be charged on

    Sa/ M/04

    New Month Starts Su/ M/05

@graboszczak
Copy link
Author

Cool! I am glad that someone else is also actively looking at the app.

The "1/2/3" issue seems to be related to the lack of "Accept-Language" HTTP header sent from the app to virgin mobile server. Apparently, VM server uses it to format the date. It works on my phone. Let me know if you are getting different results.

BTW, I would be cool if Jay / owner was so kind to update the main branch.

@pattonj
Copy link

pattonj commented Apr 12, 2013

I started looking into it about 2 months ago, but due to classes and life I haven't had any time. (I've been developing a separate app for an Advanced Android class at my college). I'm glad someone else came up with a better fix since I don't know much about scrapers (i'm also realizing how nice logcat is for finding problems).

I had to change the line in the WebsiteScraper to match the referenceScraper for it to work properly on both my Nexus 7 and Optimus V. But now it should fully work (which is now included in my previous pull request #33).

It would be really nice if Jay/owner could update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants