feat(spark-icons): add illustrations and logos #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2021
WilliamKelley
force-pushed
the
feat/prenda-art
branch
from
40eaac1 to
1be31b0
Compare
shadoath
approved these changes
Jul 16, 2021
|
Merging without Chromatic UI Review / Tests because it only adds to spark-icons and does not modify anything under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6 of 4
Followup to #135 and #138.
Addresses part of #131.
Reviewable by commit.
Adds Illustration and Logo svgs to
@prenda/spark-icons. Restores a pattern from Mui of maintaining custom / legacy icons that are copied into each generation of the larger set of icons.Allows for Illustrations and Logos to be removed from
@prenda/sparkin #146