Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spark)!: remove illustrations and logos #146

Merged
merged 2 commits into from
Jul 16, 2021
Merged

feat(spark)!: remove illustrations and logos #146

merged 2 commits into from
Jul 16, 2021

Conversation

WilliamKelley
Copy link
Contributor

@WilliamKelley WilliamKelley commented Jul 12, 2021 •
edited
Loading

Followup to #141

Only last commit is relevant.

  • Removes exports of illustrations and logos.
  • Replaces usage with imports from @prenda/spark-icons.
  • Improves stories look.
    • As you can see from the inline styles I had to set, the usage is still less than ideal for consumers. I think improving / adding utilities to SvgIcon in the future could greatly ease this use-case.

This will be blocked until we can get Chromatic review.

@WilliamKelley WilliamKelley mentioned this pull request Jul 16, 2021
Merged
@WilliamKelley WilliamKelley marked this pull request as ready for review July 16, 2021 16:38
seigler
seigler approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@seigler seigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improving / adding utilities to SvgIcon in the future

I agree

@WilliamKelley WilliamKelley marked this pull request as draft July 16, 2021 19:17
@WilliamKelley WilliamKelley marked this pull request as ready for review July 16, 2021 19:17
@WilliamKelley WilliamKelley merged commit f992374 into main Jul 16, 2021
@WilliamKelley WilliamKelley deleted the feat/art-remove branch July 16, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seigler seigler seigler approved these changes

@shadoath shadoath shadoath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilliamKelley @shadoath @seigler