Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native_expression.max_array_size_in_reduce session property #23856

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix native_expression.max_array_size_in_reduce session property #23856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public final class SystemSessionProperties

// TODO: Native execution related session properties that are temporarily put here. They will be relocated in the future.
public static final String NATIVE_SIMPLIFIED_EXPRESSION_EVALUATION_ENABLED = "native_simplified_expression_evaluation_enabled";
public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression.max_array_size_in_reduce";
public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression_max_array_size_in_reduce";
public static final String NATIVE_AGGREGATION_SPILL_ALL = "native_aggregation_spill_all";
public static final String NATIVE_MAX_SPILL_LEVEL = "native_max_spill_level";
public static final String NATIVE_MAX_SPILL_FILE_SIZE = "native_max_spill_file_size";
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class SessionProperties {
/// Reduce() function will throw an error if it encounters an array of size
/// greater than this value.
static constexpr const char* kExprMaxArraySizeInReduce =
"native_expression.max_array_size_in_reduce";
"native_expression_max_array_size_in_reduce";

/// The maximum memory used by partial aggregation when data reduction is not
/// optimal.
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ TEST_F(QueryContextManagerTest, nativeSessionProperties) {
{"native_debug_disable_expression_with_lazy_inputs", "true"},
{"native_selective_nimble_reader_enabled", "true"},
{"aggregation_spill_all", "true"},
{"native_expression.max_array_size_in_reduce", "99999"},
{"native_expression_max_array_size_in_reduce", "99999"},
}};
auto queryCtx = taskManager_->getQueryContextManager()->findOrCreateQueryCtx(
taskId, session);
Expand Down
Loading