Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#685] [fix] iOS PWA 환경에서의 status bar 스타일 추가 #687

Merged
merged 25 commits into from
Aug 19, 2024

Conversation

hanyugeon
Copy link
Member

구현 내용

  • PWA환경에서 더 이상 StatusBar가 고정 색깔로 표현되지 않아요
    • 대신 body 태그가 StatusBar의 영역을 차지합니다.
    • top-safe-area 적용으로 컨탠츠가 해당 영역을 침범하지 않도록 했습니다.
  • TopHeader를 리팩터링 했어요
    • position속성이 fixed로 바뀌었습니다.
    • 더 이상 text props에 의존적이지 않습니다. (text props를 제거되고 className props가 추가 되었어요.)
  • useIsScrollAtTop 커스텀 훅을 작성했어요
    • isScrollAtTop 변수를 통해 스크롤이 아래로 이동하면 TopHeader의 배경이 blur 처리됩니다.

스크린샷

pr 포인트

  • 리팩터링된 TopHeader 코드
  • 새로운 TopHeader가 적용된 북카이브, 도서 검색, 독서 모임, 내 프로필 코드

관련 이슈

@hanyugeon hanyugeon added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Aug 15, 2024
@hanyugeon hanyugeon requested a review from gxxrxn August 15, 2024 15:18
@hanyugeon hanyugeon self-assigned this Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 6:41am

Copy link

github-actions bot commented Aug 15, 2024

Copy link

github-actions bot commented Aug 15, 2024

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 66
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.9s
🔴 largest contentful paint 13.0s
🔴 interactive 8.3s
🟢 total blocking time 226.4ms
🟢 cumulative layout shift 0.0

gxxrxn
gxxrxn previously approved these changes Aug 18, 2024
Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인 너무 좋아요~~!! 수고 많으셨습니다!!

@@ -34,7 +34,9 @@ export const metadata: Metadata = {
{ rel: 'icon', url: '/favicon.ico' },
],
appleWebApp: {
capable: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment;

요건 어떤 속성인가요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gxxrxn

iOS 모바일 환경에서 상단 노치 부분까지 확장해서 전체화면으로 보여주도록 하는 옵션이에요!
해당 옵션을 true로 하여 BottomSheet 혹은 Menu 가 동작할때
나타나는 Dim 영역이 상단 노치 부분까지 포함 되도록 했습니다!

@hanyugeon hanyugeon merged commit d40f314 into main Aug 19, 2024
4 checks passed
@hanyugeon hanyugeon deleted the fix/#685 branch August 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] iOS PWA 환경에서의 status bar 스타일 추가
2 participants