-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#685] [fix] iOS PWA 환경에서의 status bar 스타일 추가 #687
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
757ccec
fix: apple web app status bar style 태그 추가
hanyugeon c0ac8d2
fix: statusBarStyle을 default로 수정 및 capable를 true로 명시
hanyugeon 1eaecdf
fix: manifest와 metadata에서 theme, background color 제거
hanyugeon 513809e
fix: capable, statusBarStyle 속성 추가 및 layout 상단 패딩에 safeArea 추가
hanyugeon 458eefe
fix: statusBarStyle을 black-translucent로 수정
hanyugeon ff84ff3
fix: RootLayout 패딩 값 수정
hanyugeon d52682e
feat: TopHeader safeArea값 추가 및 className props 추가
hanyugeon 5ecb565
feat: TopNavigation safeArea값 추가
hanyugeon cbaf145
fix: TopHeader 수정 이후 애니메이션이 정상작동 하도록 수정
hanyugeon 650992d
feat: manifest에 themeColor, backgroundColor 추가
hanyugeon ed5e069
fix: TopHeader에 누락된 safeArea 추가
hanyugeon f2e48a6
feat: useIsScrollAtTop 커스텀 훅 작성
hanyugeon 7c4429b
feat: TopHeader에 blur 스타일 및 props 추가
hanyugeon 797469d
refactor: 각 페이지에 변경된 TopHeader 적용
hanyugeon b1eaf7a
chore: metadata에 themeColor 다시 추가
hanyugeon 019285b
fix: PWA환경에서의 도서검색 페이지 input position 수정
hanyugeon e3c40a0
fix: 도서 검색 페이지 safeArea 수정
hanyugeon ace6a8f
fix: 도서 검색 페이지 translate값 수정
hanyugeon 2c464cc
refactor: TopHeader 컴포넌트의 text props의존성을 제거
hanyugeon 20c766c
fix: 각 페이지의 리팩토링 된 TopHeader 적용
hanyugeon a6d6bbb
fix: PWA환경에서 상단 노치부분에 컨탠츠가 노출되던 현상 수정
hanyugeon a4a97cb
fix: body 스크롤 시 컨탠츠가 좁은 틈새로 보이는 버그 수정
hanyugeon 27e113b
fix: PWA환경에서 Login 페이지의 로그인 섹션이 비정상적인 위치에 있던 버그 수정
hanyugeon 0c952bf
fix: TopHeader 스토리북에 appLayoutMeta 적용
hanyugeon a3fd60c
feat: 도서 검색 페이지에 누락된 TopHeader blur 추가
hanyugeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { useEffect, useState } from 'react'; | ||
|
||
const useIsScrollAtTop = () => { | ||
const [isScrollAtTop, setIsScrollAtTop] = useState(true); | ||
|
||
const listener = () => { | ||
setIsScrollAtTop(window.scrollY === 0); | ||
}; | ||
|
||
useEffect(() => { | ||
window.addEventListener('scroll', listener); | ||
return () => { | ||
window.removeEventListener('scroll', listener); | ||
}; | ||
}, []); | ||
|
||
return { isScrollAtTop }; | ||
}; | ||
|
||
export default useIsScrollAtTop; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,44 @@ | ||
import { Meta, StoryObj } from '@storybook/react'; | ||
|
||
import { IconHamburger } from '@public/icons'; | ||
import TopHeader from '@/components/common/TopHeader'; | ||
|
||
import { appLayoutMeta } from '@/stories/meta'; | ||
|
||
const meta: Meta<typeof TopHeader> = { | ||
title: 'Common/TopHeader', | ||
component: TopHeader, | ||
tags: ['autodocs'], | ||
...appLayoutMeta, | ||
}; | ||
|
||
export default meta; | ||
|
||
type Story = StoryObj<typeof TopHeader>; | ||
|
||
export const Default: Story = { | ||
args: { text: 'BookArchive' }, | ||
render: args => <TopHeader {...args} />, | ||
render: () => ( | ||
<TopHeader> | ||
<h1 className="text-main-900 font-heading-bold">BookArchive</h1> | ||
</TopHeader> | ||
), | ||
}; | ||
|
||
export const WithMenu: Story = { | ||
args: { text: 'Profile' }, | ||
export const WithChildren: Story = { | ||
args: { | ||
className: 'flex items-center justify-between', | ||
}, | ||
render: args => ( | ||
<TopHeader {...args}> | ||
<button | ||
onClick={() => { | ||
alert('HAMBURGUR MENU!🍔'); | ||
}} | ||
> | ||
<IconHamburger width={20} height={20} alt="햄버거메뉴" /> | ||
</button> | ||
</TopHeader> | ||
<main className="w-full max-w-[43rem] bg-black-300"> | ||
<TopHeader {...args}> | ||
<h1 className="text-main-900 font-heading-bold">Profile</h1> | ||
<button | ||
onClick={() => { | ||
alert('HAMBURGUR MENU!🍔'); | ||
}} | ||
> | ||
<IconHamburger width={20} height={20} alt="햄버거메뉴" /> | ||
</button> | ||
</TopHeader> | ||
</main> | ||
), | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment;
요건 어떤 속성인가요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gxxrxn
iOS 모바일 환경에서 상단 노치 부분까지 확장해서 전체화면으로 보여주도록 하는 옵션이에요!
해당 옵션을 true로 하여
BottomSheet
혹은Menu
가 동작할때나타나는 Dim 영역이 상단 노치 부분까지 포함 되도록 했습니다!