Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming prior to the delivery of the work about "NFC Commissioning". #36555

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/nrfconnect/chip-module/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ matter_add_cxxflags(${ZEPHYR_GNU_CPP_STD})
# Set up custom OpenThread configuration

if (CONFIG_CHIP_OPENTHREAD_CONFIG)
get_filename_component(CHIP_OPENTHREAD_CONFIG
get_filename_component(CHIP_OPENTHREAD_CONFIG
${CONFIG_CHIP_OPENTHREAD_CONFIG}
REALPATH
BASE_DIR ${CMAKE_SOURCE_DIR}
Expand Down Expand Up @@ -125,7 +125,7 @@ matter_add_gn_arg_bool ("chip_enable_openthread" CONFIG_NET_L2_
matter_add_gn_arg_bool ("chip_openthread_ftd" CONFIG_OPENTHREAD_FTD)
matter_add_gn_arg_bool ("chip_config_network_layer_ble" CONFIG_BT)
matter_add_gn_arg_bool ("chip_inet_config_enable_ipv4" CONFIG_CHIP_IPV4)
matter_add_gn_arg_bool ("chip_enable_nfc" CONFIG_CHIP_NFC_COMMISSIONING)
matter_add_gn_arg_bool ("chip_enable_nfc_onboarding" CONFIG_CHIP_NFC_ONBOARDING)
matter_add_gn_arg_bool ("chip_enable_ota_requestor" CONFIG_CHIP_OTA_REQUESTOR)
matter_add_gn_arg_bool ("chip_persist_subscriptions" CONFIG_CHIP_PERSISTENT_SUBSCRIPTIONS)
matter_add_gn_arg_bool ("chip_monolithic_tests" CONFIG_CHIP_BUILD_TESTS)
Expand Down
2 changes: 1 addition & 1 deletion config/qpg/chip-gn/args.gni
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ lwip_debug = false
chip_enable_openthread = true
chip_config_network_layer_ble = true
chip_inet_config_enable_ipv4 = false
chip_enable_nfc = false
chip_enable_nfc_onboarding = false
chip_build_tests = false
chip_monolithic_tests = false
chip_inet_config_enable_tcp_endpoint = false
Expand Down
4 changes: 2 additions & 2 deletions config/telink/chip-module/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ matter_add_flags(-DMBEDTLS_USER_CONFIG_FILE=<telink-mbedtls-config.h>)
# Set up custom OpenThread configuration

if (CONFIG_CHIP_OPENTHREAD_CONFIG)
get_filename_component(CHIP_OPENTHREAD_CONFIG
get_filename_component(CHIP_OPENTHREAD_CONFIG
${CONFIG_CHIP_OPENTHREAD_CONFIG}
REALPATH
BASE_DIR ${CMAKE_SOURCE_DIR}
Expand All @@ -96,7 +96,7 @@ matter_add_gn_arg_bool ("chip_enable_openthread" CONFIG_NET_L2_
matter_add_gn_arg_bool ("chip_openthread_ftd" CONFIG_OPENTHREAD_FTD)
matter_add_gn_arg_bool ("chip_config_network_layer_ble" CONFIG_BT)
matter_add_gn_arg_bool ("chip_inet_config_enable_ipv4" CONFIG_CHIP_IPV4)
matter_add_gn_arg_bool ("chip_enable_nfc" CONFIG_CHIP_NFC_COMMISSIONING)
matter_add_gn_arg_bool ("chip_enable_nfc_onboarding" CONFIG_CHIP_NFC_ONBOARDING)
matter_add_gn_arg_bool ("chip_enable_ota_requestor" CONFIG_CHIP_OTA_REQUESTOR)
matter_add_gn_arg_bool ("chip_inet_config_enable_tcp_endpoint" FALSE)
matter_add_gn_arg_bool ("chip_error_logging" CONFIG_MATTER_LOG_LEVEL GREATER_EQUAL 1)
Expand Down
10 changes: 5 additions & 5 deletions docs/platforms/nrf/nrfconnect_examples_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,13 @@ intervals:
- `CONFIG_CHIP_ICD_SLOW_POLL_INTERVAL`
- `CONFIG_CHIP_ICD_FAST_POLLING_INTERVAL`

#### Commissioning with NFC support
#### Onboarding with NFC support

You can configure the Matter protocol to use an NFC tag for commissioning,
instead of using a QR code, which is the default configuration.
You can configure the Matter protocol to use an NFC tag for onboarding, instead
of using a QR code, which is the default configuration.

To enable NFC for commissioning and share the onboarding payload in an NFC tag,
set the `CONFIG_CHIP_NFC_COMMISSIONING` option.
To enable NFC for onboarding and share the onboarding payload in an NFC tag, set
the `CONFIG_CHIP_NFC_ONBOARDING` option.

#### Factory reset behavior

Expand Down
6 changes: 3 additions & 3 deletions examples/all-clusters-app/nrfconnect/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
switch (event->Type)
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -501,7 +501,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
switch (event->Type)
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -420,7 +420,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
8 changes: 4 additions & 4 deletions examples/contact-sensor-app/nxp/k32w0/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -779,23 +779,23 @@ void AppTask::MatterEventHandler(const ChipDeviceEvent * event, intptr_t)
}
#endif

#if CONFIG_CHIP_NFC_COMMISSIONING
#if CONFIG_CHIP_NFC_ONBOARDING
if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange && event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
if (!NFCMgr().IsTagEmulationStarted())
if (!NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already stopped!");
}
else
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
K32W_LOG("Stopped NFC Tag Emulation!");
}
}
else if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange &&
event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already started!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
6 changes: 3 additions & 3 deletions examples/light-switch-app/nrfconnect/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
UpdateStatusLED();
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -480,7 +480,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
6 changes: 3 additions & 3 deletions examples/lighting-app/nrfconnect/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
switch (event->Type)
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -607,7 +607,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
8 changes: 4 additions & 4 deletions examples/lighting-app/nxp/k32w0/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -678,23 +678,23 @@ void AppTask::MatterEventHandler(const ChipDeviceEvent * event, intptr_t)
}
#endif

#if CONFIG_CHIP_NFC_COMMISSIONING
#if CONFIG_CHIP_NFC_ONBOARDING
if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange && event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
if (!NFCMgr().IsTagEmulationStarted())
if (!NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already stopped!");
}
else
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
K32W_LOG("Stopped NFC Tag Emulation!");
}
}
else if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange &&
event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already started!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
6 changes: 3 additions & 3 deletions examples/lit-icd-app/nrfconnect/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
switch (event->Type)
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -501,7 +501,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
6 changes: 3 additions & 3 deletions examples/lock-app/nrfconnect/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,10 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
switch (event->Type)
{
case DeviceEventType::kCHIPoBLEAdvertisingChange:
#ifdef CONFIG_CHIP_NFC_COMMISSIONING
#ifdef CONFIG_CHIP_NFC_ONBOARDING
if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
LOG_INF("NFC Tag emulation is already started");
}
Expand All @@ -561,7 +561,7 @@ void AppTask::ChipEventHandler(const ChipDeviceEvent * event, intptr_t /* arg */
}
else if (event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
}
#endif
sHaveBLEConnections = ConnectivityMgr().NumBLEConnections() != 0;
Expand Down
8 changes: 4 additions & 4 deletions examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -608,23 +608,23 @@ void AppTask::MatterEventHandler(const ChipDeviceEvent * event, intptr_t)
}
}

#if CONFIG_CHIP_NFC_COMMISSIONING
#if CONFIG_CHIP_NFC_ONBOARDING
if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange && event->CHIPoBLEAdvertisingChange.Result == kActivity_Stopped)
{
if (!NFCMgr().IsTagEmulationStarted())
if (!NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already stopped!");
}
else
{
NFCMgr().StopTagEmulation();
NFCOnboardingMgr().StopTagEmulation();
K32W_LOG("Stopped NFC Tag Emulation!");
}
}
else if (event->Type == DeviceEventType::kCHIPoBLEAdvertisingChange &&
event->CHIPoBLEAdvertisingChange.Result == kActivity_Started)
{
if (NFCMgr().IsTagEmulationStarted())
if (NFCOnboardingMgr().IsTagEmulationStarted())
{
K32W_LOG("NFC Tag emulation is already started!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_TIMEOUT (15 * 60 * 1000)

/**
* CONFIG_CHIP_NFC_COMMISSIONING, CHIP_DEVICE_CONFIG_ENABLE_NFC
* CONFIG_CHIP_NFC_ONBOARDING, CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING
*
* NFC commissioning is not supported on K32W1
* NFC onboarding is not supported on K32W1
*/
#define CONFIG_CHIP_NFC_COMMISSIONING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC 0
#define CONFIG_CHIP_NFC_ONBOARDING 0
#define CHIP_DEVICE_CONFIG_ENABLE_NFC_ONBOARDING 0

/**
* @def CHIP_CONFIG_MAX_FABRICS
Expand Down
Loading
Loading