Add slippi logo to waiting for game #86
Conversation
…ixed a crash in GObj_AddObject call (the GOBJ we create is initialized with a bad obj_kind for some reason)
…I made more gobjs, which unfortunately broke everything. I'm committing here so I can do some experiments and return to this baseline
…se is relying on it.
…ull for obj_kind is 1 now, not sure if that's actually appropriate). i realized i probably wasn't calling Jobj_Loadjoint with the correct pointer, i haven't verified that that is now correct because File_Load seems not to be loading the whole file, just the first 4 words :/
…ogo still not displaying lole
…, so I am trying that instead (still didnt work).
|
IMO:
|
| @@ -123,6 +123,12 @@ | |||
| "isRecursive": true, | |||
| "annotation": "Functions for supporting FFW [Fizzi, Unclepunch]" | |||
| }, | |||
| { | |||
| "type": "injectFolder", | |||
| "sourceFolder": "Online/Core/EXIFileLoad", | |||
There was a problem hiding this comment.
@JordanLozinski
@JLaferri might be a good idea to move this to commons, since it found its way to non online usages.
There was a problem hiding this comment.
Not sure if you're asking me to move that as part of this PR or just suggesting this as future work
| DATA_BLRL: | ||
| blrl | ||
| # File related strings | ||
| .string "slpLogo.dat" |
There was a problem hiding this comment.
@JordanLozinski could you reuse the existing slippi dat files?
Looks cumbersome to have a whole .dat file just for the logo.
The .dat file that has the css chat stuff could share this logo.
If the current name implies that its only for the css, then I think its fine to just rename it.
Theres not that much stuff in it for it to be a memory issue, if it becomes one it can just separated in the future as "slpCommons" or something like that.
There was a problem hiding this comment.
I think it's probably better to have a separate one for different scenes tbh. That's what the game normally does.
There was a problem hiding this comment.
I think it's probably better to have a separate one for different scenes tbh. That's what the game normally does.
The game does reuses common dat files, which I can see this one being part of.
I.e: theres a common menu dat file the game uses for different scenes on the main menu, 1p css, vs scenes etc. Cant recall the exact name of it right now though it also does it for some other files.
There was a problem hiding this comment.
slpLogo is a SOBJ with a JOBJDesc array and a CObjDesc array, and slpCSS is a JOBJDesc, so I'll need to make slpCSS part of the array in slpLogo, and then rewrite and test the stuff that pulls the chat window jobjdesc from the file. I'm reluctant to potentially break or compromise the chat functionality for a small benefit.
However we can rename slpLogo to slpCommons or something and use it for miscellaneous jobjs, camdescs, lights, etc. in the future
|
New design: |
|
The widescreen code was messing up the xscale/xpos of the logo. That's fixed as of a551fc0. |
https://github.com/orgs/project-slippi/projects/1#card-47932325.
Paired with project-slippi/Ishiiruka#350