Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clone images to local oci repo before building #518

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

smoser
Copy link
Contributor

@smoser smoser commented Oct 3, 2023

This adds a make target 'docker-clone' which will copy the required docker images to a local oci dir specified by CLONE_D.

You can then use that oci dir as STACKER_DOCKER_BASE.

So:

make docker-clone CLONE_D=/tmp/my-oci
export STACKER_DOCKER_BASE=oci:/tmp/my-oci:
make ...

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #518 (366ea01) into main (96dbbe5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   13.14%   13.14%           
=======================================
  Files          40       40           
  Lines        5712     5712           
=======================================
  Hits          751      751           
  Misses       4837     4837           
  Partials      124      124           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smoser smoser force-pushed the fix/less-docker-io-dependence branch from b003fce to 12d438a Compare October 3, 2023 01:54
This adds a make target 'docker-clone' which will copy the required
docker images to a local oci dir specified by CLONE_D.

You can then use that oci dir as STACKER_DOCKER_BASE.

So:

    make docker-clone CLONE_D=/tmp/my-oci
    export STACKER_DOCKER_BASE=oci:/tmp/my-oci:
    make ...

Signed-off-by: Scott Moser <[email protected]>
@smoser smoser force-pushed the fix/less-docker-io-dependence branch from 12d438a to 366ea01 Compare October 3, 2023 14:23
@hallyn hallyn merged commit 957000a into project-stacker:main Oct 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants