Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plot state #157

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Feature/plot state #157

merged 8 commits into from
Dec 14, 2023

Conversation

BaxterEaves
Copy link
Contributor

  • Added state.plot in pylace to plot PCC states
  • FIXED indexing bug in pylace.Engine which would return rows in a random order. The order seemed to be fixed on engine creation, which indicates to me that it was tied to some sort of random state used in the hashmap.

Baxter Eaves added 5 commits November 30, 2023 17:02
the order of rows when single indexing, e.g., `engine[column]` would be
differente each time you initialized the engine, and would not
correspond to the order of rows in the row index. Fixed it.
@BaxterEaves BaxterEaves requested a review from a team as a code owner December 4, 2023 16:42
Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good. Just a question and a cleanup.

pylace/lace/plot.py Show resolved Hide resolved
pylace/src/utils.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed it, mostly for documentation. LGTM!

@BaxterEaves BaxterEaves merged commit 82940ee into master Dec 14, 2023
7 of 8 checks passed
@schmidmt schmidmt deleted the feature/plot-state branch May 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants