Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pylace removable rows #195

Merged
merged 6 commits into from
May 3, 2024

Conversation

schmidmt
Copy link
Contributor

No description provided.

@schmidmt schmidmt requested a review from BaxterEaves April 25, 2024 22:43
@schmidmt schmidmt self-assigned this Apr 25, 2024
@schmidmt schmidmt requested a review from a team as a code owner April 25, 2024 22:43
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions; some of this confused me

pylace/src/lib.rs Outdated Show resolved Hide resolved
pylace/src/lib.rs Show resolved Hide resolved
pylace/src/lib.rs Outdated Show resolved Hide resolved
pylace/src/metadata.rs Outdated Show resolved Hide resolved
pylace/src/metadata.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/python-build-test.yaml Outdated Show resolved Hide resolved
@schmidmt schmidmt force-pushed the feature/pylace-removable-rows branch from d7d6bb2 to 83634ea Compare May 2, 2024 15:42
… an existing one

fixup: Updated based on comments from @Swandog
@schmidmt schmidmt force-pushed the feature/pylace-removable-rows branch from 83634ea to 2c6508a Compare May 2, 2024 22:33
@schmidmt schmidmt force-pushed the feature/pylace-removable-rows branch from 2c6508a to 5b56e65 Compare May 3, 2024 03:02
@schmidmt schmidmt merged commit 4092fdf into feature/pitman-yor May 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants