Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Israel sources #476

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Conversation

yotamN
Copy link
Contributor

@yotamN yotamN commented Aug 31, 2024

I've sent a message to Busofash regarding their error in the GTFS file.

@vkrause
Copy link
Member

vkrause commented Aug 31, 2024

The second one passes locally with the following change and #477:

        {
            "name": "Israel-MOT",
            "type": "transitland-atlas",
            "transitland-atlas-id": "f-sv-גלים~מועצהאזוריתגולן~אפיקים~דןצפון~דןבדרום~דןבארשבע~ירושלים",
            "http-options": {
                "ignore-tls-errors": true,
                "headers": {
                    "user-agent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
                }
            },
            "fix": true
        }

@yotamN
Copy link
Contributor Author

yotamN commented Aug 31, 2024

Will try your configuration but it seems that Transitland was last updated 5 months ago, not so up-to-date.

@yotamN yotamN force-pushed the feature/israel branch 3 times, most recently from 7d9146a to 2c20e0a Compare September 7, 2024 10:46
@yotamN
Copy link
Contributor Author

yotamN commented Sep 7, 2024

Still not sure why Israel-MOT is closing the connection so I skipped it for now

feeds/il.json Outdated
"url": "https://gtfs.mot.gov.il/gtfsfiles/israel-public-transportation.zip",
"http-options": {
"headers": {
"user-agent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the HTTP RFCs state that the header field names should be case-insensitive, is this always true in practice? I think I've mostly seen "User-Agent" being used.
Maybe it could be worth trying to changing to that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to make https://github.com/public-transport/transitous/blob/main/src/fetch.py#L60 case-insensitive as well then.

@jbruechert jbruechert merged commit 32a2dd3 into public-transport:main Feb 15, 2025
4 checks passed
@jbruechert
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants