Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitous configuration #104

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Update transitous configuration #104

merged 5 commits into from
Feb 14, 2025

Conversation

1Maxnet1
Copy link
Collaborator

@1Maxnet1 1Maxnet1 commented Feb 5, 2025

This includes:

  • fixes a typo
  • extend coverage
  • MOTIS-Version update
  • change endpoint

@vkrause
Copy link
Member

vkrause commented Feb 11, 2025

Thanks for looking into this!

For some countries we can make this a bit more specific I think, as we only cover parts of those so far and would create false positive coverage claims in relatively large areas otherwise:

  • BR: BR-RS, BR-RJ
  • MX: MX-MEX
  • MY: MY-01, MY-02, MY-03, MY-04, MY-05, MY-06, MY-08, MY-09, MY-07, MY-10, MY-11, MY-14, MY-16 (ie. just Peninsular Malaysia)
  • OM: OM-MA
  • UA: UA-46

For the following countries I see feeds but no activity on the map:

  • CO
  • IL
  • JP
  • PR

Not sure what to do best about those.

@1Maxnet1
Copy link
Collaborator Author

For some countries we can make this a bit more specific I think, as we only cover parts of those so far and would create false positive coverage claims in relatively large areas otherwise

Sure, will update the coverage accordingly.

Not sure what to do best about those

If there is nothing available on the map, I will double-check transitous and create according issues and ping the maintainers. Would leave them out for now and they can be re-added in the next coverage update :)

@1Maxnet1
Copy link
Collaborator Author

For CO columbia there are vehicles on the map and trips available, but we can also get more specific, as it only covers CO-DC

@1Maxnet1
Copy link
Collaborator Author

1Maxnet1 commented Feb 12, 2025

For the following countries I see feeds but no activity on the map:

CO -> CO-DC
IL -> skip as the PR is still open and the master branch does not have a feed yet (public-transport/transitous#476)
JP -> JP-13 and JP-34
PR -> Indeed seems no activity: public-transport/transitous#883 will remove it from the configuration for now

@vkrause
Copy link
Member

vkrause commented Feb 12, 2025

LGTM. PR seems to be fixed as well now, so we can probably include that after all as well.

@1Maxnet1 1Maxnet1 self-assigned this Feb 14, 2025
@1Maxnet1
Copy link
Collaborator Author

LGTM. PR seems to be fixed as well now, so we can probably include that after all as well.

I consider this an approval :) If there are any further issues, we can still fix them in the next PRs, as I expect transitous will probably further increase it's coverage. Additionally, one could in general be more specific about the realtime coevrage as weel, but that's up to another PR

@1Maxnet1 1Maxnet1 merged commit b66976f into v1 Feb 14, 2025
4 checks passed
@1Maxnet1 1Maxnet1 deleted the update-transitous branch February 14, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants