tools: skip contract date rendering, small CI fixups. #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICANN is updating the contract date field in the `gtlds.json` file for many contracts in the near future. Since including the contract date in the `.dat` file as comments isn't very helpful to anyone, and leaving it in during this renewal period would result in a large quantity of auto-pull requests for no-op changes, we choose to omit the date as a quick fix. This commit updates the `newtlds.go` tool to no longer process/render the `DateOfContractSignature`. Unit tests are updated to reflect this change.
Previously the Go unit tests for the `newgtlds` tool were run as part of the Travis workflow for each branch push. This is helpful to catch breaking changes to the Go tooling _before_ they are merged and used in the `tld-update.yml` workflow. This commit adds the required steps to `test.yml` so that these unit tests are run by GitHub actions similar to the way they were for Travis.
The comment about the automation being on-hold was leftover from a period ~two years ago. It isn't accurate, the automation _has_ been running, and it properly handles the header timestamp issue that caused it to be temporarily disabled.
dnsguru
added
✅ autopull
dnsguru
added
NOT IOS FB
weppos
approved these changes
Aug 1, 2023
|
Fixes #1806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #1809
More cleanup is probably in order (in particular, making a proper Go module for this tool) but for now let's do the simple stuff.
tools: don't render date of contract signature.
ICANN is updating the contract date field in the
gtlds.jsonfile for many contracts in the near future. Since including the contract date in the.datfile as comments isn't very helpful to anyone, and leaving it in during this renewal period would result in a large quantity of auto-pull requests for no-op changes, we choose to omit the date as a quick fix.This commit updates the
newtlds.gotool to no longer process/render theDateOfContractSignature. Unit tests are updated to reflect this change.ci: run Go unit tests as part of test.yml.
Previously the Go unit tests for the
newgtldstool were run as part of the Travis workflow for each branch push. This is helpful to catch breaking changes to the Go tooling before they are merged and used in thetld-update.ymlworkflow.This commit adds the required steps to
test.ymlso that these unit tests are run by GitHub actions similar to the way they were for Travis.ci: switch to latest stable go.
Does what it says on the tin.
ci: remove stale comment in tld-update.yml
The comment about the automation being on-hold was leftover from a period ~two years ago. It isn't accurate, the automation has been running, and it properly handles the header timestamp issue that caused it to be temporarily disabled.
Meta discussion
Speaking frankly: I find it hard to prioritize supporting this automation. I'm not a maintainer of this repo, I don't have as much stake in the PSL as when I worked at Let's Encrypt, I've been writing less Go lately, and I have other hobby projects to spend my free time on :-)
I'd be happy for someone else to take over maintenance and future development. Alternatively, if Mozilla or another organization has funding I'm available for part-time contract work.
However, since I know many of the folks involved here are volunteers and the PSL is load bearing for the broader internet I will continue to help where I can if there aren't better alternatives. Mostly I feel it's important to lay my cards on the table to help set expectations.