Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite for pvlib v0.9.0 #115

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

kandersolar
Copy link
Member

Description

This PR updates the test suite to not use the orientation_strategy ModelChain parameter (removed in v0.9.0). Here is an example failed CI run from #114: https://github.com/pvlib/pvanalytics/runs/4398633530?check_suite_focus=true

At some point we will need to stop using SingleAxisTracker as well, but it still works for now.

Checklist

The following items must be addressed before the code can be merged.
Please don't hesitate to ask for help if you are unsure of how to accomplish any of the items.
You are free to remove any checklist items that do not apply or add additional items that are
not on this list

  • Closes #xxx
  • Added new API functions to docs/api.rst
  • Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings
  • Adds description and name entries in the appropriate "what's new" file
    in docs/whatsnew
    for all changes. Includes link to the GitHub Issue with :issue:`num`
    or this Pull Request with :pull:`num`. Includes contributor name
    and/or GitHub username (link with :ghuser:`user`).
  • Non-API functions clearly documented with docstrings or comments as necessary
  • Added tests to cover all new or modified code
  • Pull request is nearly complete and ready for detailed review

@kandersolar kandersolar added the tests Something is wrong with the test suite label Dec 2, 2021
@cwhanse
Copy link
Member

cwhanse commented Dec 2, 2021

@kanderso-nrel the "reno" test failures are known #105 and not a blocker here. Can we skip those tests for now?

@kandersolar
Copy link
Member Author

We marked them as expected to fail in #106, so I think a failure here means that the tests are actually passing. I haven't been keeping track of the changes to that function so maybe that's expected. In any case those two tests should be skipped entirely now.

@kandersolar
Copy link
Member Author

Failures are all coveralls, and the coverage changes are all related to clearsky.reno. So I think this is good to go

@wfvining
Copy link
Collaborator

wfvining commented Dec 2, 2021

In addition to removing the use of SingleAxisTracker at some point we should also use the new PVSystem + Array.

@cwhanse
Copy link
Member

cwhanse commented Dec 2, 2021

In addition to removing the use of SingleAxisTracker at some point we should also use the new PVSystem + Array.

#116

@kandersolar
Copy link
Member Author

Ok, with two approving reviews I'll go ahead and merge. Thanks @cwhanse and @wfvining

@kandersolar kandersolar merged commit bb451a0 into pvlib:master Dec 3, 2021
@kandersolar kandersolar deleted the pytest_fixes branch December 3, 2021 14:30
@kandersolar kandersolar added this to the v0.1.1 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Something is wrong with the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants