Add an option to set a destination directory for the simulation output #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e0a99ab and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 47.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.0% (-0.7% change). View more on Code Climate. |
|
Moved to #34 . The problem with the failing test was, that a PR from a fork does not have access to the repo-secrets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option to specify a destination directory for the simulation data. This is to support submission from AFS, but file storage on EOS. When an output directory is specified, the job directory structure is replicated there and the output from the jobs is routed there via job script amendment. The default for this new option is None and the submission behaves as it does now.