Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary function and lots of linting #132

Merged
merged 78 commits into from
Aug 15, 2024
Merged

Remove unnecessary function and lots of linting #132

merged 78 commits into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. IOError is now OSError in CPython, do not need to inherit from object

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dfce7e4 View commit details
    Browse the repository at this point in the history

  2. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2fb0b27 View commit details
    Browse the repository at this point in the history

  3. delay annotations to allow TfsCollection hints

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    298143e View commit details
    Browse the repository at this point in the history

  4. remove trailing whitespaces

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    678112c View commit details
    Browse the repository at this point in the history

  5. type checking block

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7e6e6fd View commit details
    Browse the repository at this point in the history

  6. remove trailing whitespaces

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    155bf59 View commit details
    Browse the repository at this point in the history

  7. __new__ is classmethod, should have cls as first argument

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    64024e8 View commit details
    Browse the repository at this point in the history

  8. no implicit none

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    45c2627 View commit details
    Browse the repository at this point in the history

  9. error messages should be defined outside raise statement

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    27dbefd View commit details
    Browse the repository at this point in the history

  10. ignore unused args and kwargs in abstractmethod signature

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    cd57cfa View commit details
    Browse the repository at this point in the history

  11. unnecessary else

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    18c4401 View commit details
    Browse the repository at this point in the history

  12. ignore for legitimate reasons, minor formatting

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a9255a2 View commit details
    Browse the repository at this point in the history

  13. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8c3a929 View commit details
    Browse the repository at this point in the history

  14. no pass statement in exception definition

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c267c8b View commit details
    Browse the repository at this point in the history

  15. get Sequence from collections.abc

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8c702db View commit details
    Browse the repository at this point in the history

  16. remove trailing whitespaces

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fe40bc2 View commit details
    Browse the repository at this point in the history

  17. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4c22c94 View commit details
    Browse the repository at this point in the history

  18. mutable class var should be type hinted ClassVar

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    504e544 View commit details
    Browse the repository at this point in the history

  19. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    73cca17 View commit details
    Browse the repository at this point in the history

  20. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d2c2e31 View commit details
    Browse the repository at this point in the history

  21. reraise from previous error

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c8eb8ce View commit details
    Browse the repository at this point in the history

  22. also reraise from full stacktrace here

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5a740da View commit details
    Browse the repository at this point in the history

  23. PEP 604 unions and avoid implicit optional

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    efd6a4c View commit details
    Browse the repository at this point in the history

  24. type checking block

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f6c16a0 View commit details
    Browse the repository at this point in the history

  25. let ruff know we target python 3.9

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    444b9ef View commit details
    Browse the repository at this point in the history

  26. PEP 604 unions

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ad1899a View commit details
    Browse the repository at this point in the history

  27. put annotation-only type in TYPE_CHECKING block

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    608d5d6 View commit details
    Browse the repository at this point in the history

  28. Use key in dict instead of key in dict.keys()

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4cadb94 View commit details
    Browse the repository at this point in the history

  29. remove trailing whitespaces

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    91b5dcc View commit details
    Browse the repository at this point in the history

  30. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    55792a6 View commit details
    Browse the repository at this point in the history

  31. use contextlib to suppress a specific error instead of try-except-pass

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    30a2e16 View commit details
    Browse the repository at this point in the history

  32. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f6d408c View commit details
    Browse the repository at this point in the history

  33. PEP 604 unions and avoid implicit optional

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    16aafd9 View commit details
    Browse the repository at this point in the history

  34. stop caring about boolean arg

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4bbaeb5 View commit details
    Browse the repository at this point in the history

  35. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3072887 View commit details
    Browse the repository at this point in the history

  36. reraise from previous error

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d744629 View commit details
    Browse the repository at this point in the history

  37. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c54bf6e View commit details
    Browse the repository at this point in the history

  38. stop caring about boolean arg

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8269df6 View commit details
    Browse the repository at this point in the history

  39. PEP 604 unions

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b354c92 View commit details
    Browse the repository at this point in the history

  40. put annotation-only type in TYPE_CHECKING block

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b8b4fdc View commit details
    Browse the repository at this point in the history

  41. stop caring about boolean arg

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9275220 View commit details
    Browse the repository at this point in the history

  42. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    41dbf3d View commit details
    Browse the repository at this point in the history

  43. lets not overwrite the loop variable

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    efb46af View commit details
    Browse the repository at this point in the history

  44. use PEP 585 annotations

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    eaef978 View commit details
    Browse the repository at this point in the history

  45. PEP 604 unions and avoid implicit optional

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    00df787 View commit details
    Browse the repository at this point in the history

  46. stop caring about boolean arg

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7c55048 View commit details
    Browse the repository at this point in the history

  47. remove trailing whitespaces

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e78e923 View commit details
    Browse the repository at this point in the history

  48. unnecessary else after return

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    78f0bff View commit details
    Browse the repository at this point in the history

  49. no need to restate the raise error name

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6a3ee88 View commit details
    Browse the repository at this point in the history

  50. remove _autoset_pandas_types as we prohibit pandas <2.1 and the need … 

    …for this workaround was only for pandas up to 1.3 (excluded) in which they fixed the problem. See the NOTE in the deleted function and the github comment it links to
    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a9ea55d View commit details
    Browse the repository at this point in the history

  51. Exception must not use a string literal, assign to variable first

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    696f694 View commit details
    Browse the repository at this point in the history

  52. use startswith with a tuple instead of several checks

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a4e0072 View commit details
    Browse the repository at this point in the history

  53. use single if statement instead of nested ones

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7d6ce93 View commit details
    Browse the repository at this point in the history

  54. unnecessary assignment before return

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3fec4de View commit details
    Browse the repository at this point in the history

  55. elifs can be ifs since theyre after return statements

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c1549c0 View commit details
    Browse the repository at this point in the history

  56. minimal formatting

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9b9a615 View commit details
    Browse the repository at this point in the history

  57. Use key in dict instead of key in dict.keys()

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2842aff View commit details
    Browse the repository at this point in the history

  58. stop caring about boolean arg

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    21f299c View commit details
    Browse the repository at this point in the history

  59. set match in pytest.raises as it was too broad

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d5d9ad8 View commit details
    Browse the repository at this point in the history

  60. Use key in dict instead of key in dict.keys()

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b1d9e48 View commit details
    Browse the repository at this point in the history

  61. remove unused caplogs

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    827595e View commit details
    Browse the repository at this point in the history

  62. set match in pytest.raises as it was too broad

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5492297 View commit details
    Browse the repository at this point in the history

  63. should assign in access expressions

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4df0b4d View commit details
    Browse the repository at this point in the history

  64. asserts should only check one thing

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a9ad1fd View commit details
    Browse the repository at this point in the history

  65. unused import and orders

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9ffd6ae View commit details
    Browse the repository at this point in the history

  66. set match in pytest.raises as it was too broad

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e1bd0cc View commit details
    Browse the repository at this point in the history

  67. Use key in dict instead of key in dict.keys()

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7a9680c View commit details
    Browse the repository at this point in the history

  68. remove unused caplogs

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    419c416 View commit details
    Browse the repository at this point in the history

  69. pandas as pd, numpy as np

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dcdcbf2 View commit details
    Browse the repository at this point in the history

  70. remove unused caplogs

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7440023 View commit details
    Browse the repository at this point in the history

  71. use dict literal

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    41748ec View commit details
    Browse the repository at this point in the history

  72. oops

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    83d9da8 View commit details
    Browse the repository at this point in the history

  73. help josch's eyes

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    862e9e4 View commit details
    Browse the repository at this point in the history

  74. bit more formatting consistency

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c160f80 View commit details
    Browse the repository at this point in the history

  75. no need for these skipifs as the condition no longer applies

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8142219 View commit details
    Browse the repository at this point in the history

  76. again an unused import

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f056f4b View commit details
    Browse the repository at this point in the history

  77. add in progress to the changelog

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f2ceff2 View commit details
    Browse the repository at this point in the history

  78. noqa on the correct line again

    @fsoubelet
    fsoubelet committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    18881a7 View commit details
    Browse the repository at this point in the history