Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hypothesis trove classifier for pytest-trio #68

Merged
merged 1 commit into from
Dec 9, 2018

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Oct 31, 2018

Since PR #44, pytest-trio has had special handling that allows @hypothesis.given(...) for Trio tests even though they are async functions. This PR is a trivial update to add the new Framework :: Hypothesis trove classifier (:tada:), as discussed in HypothesisWorks/hypothesis#1663, so that users can more easily tell from the metadata.

@Zac-HD
Copy link
Member Author

Zac-HD commented Oct 31, 2018

Uh. Looks like trio has updated with some new deprecation warnings, and pytest-trio isn't pinning the version it tests against...

@njsmith
Copy link
Member

njsmith commented Nov 1, 2018

Oh cool, congrats on the new classifier! We should definitely add that.

Re: the pinning... yeah. I filed #69 to avoid these issues in the future. I'm a bit swamped this week so not sure if I'll get to it any time soon.

It looks like the actual test failures are all due to trio-asyncio using the deprecated Queue functionality rather than anything in pytest-trio. I guess the most correct fix, and possibly also the simplest, would be to fix trio-asyncio and make a release?

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          19       19           
  Lines         461      461           
  Branches       43       43           
=======================================
  Hits          458      458           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f2ba7...e7fd67a. Read the comment docs.

@Zac-HD Zac-HD merged commit 5df0bde into python-trio:master Dec 9, 2018
@Zac-HD Zac-HD deleted the hypothesis-classifier branch December 9, 2018 11:54
@Zac-HD
Copy link
Member Author

Zac-HD commented Dec 9, 2018

@njsmith @touilleMan a release to get this up on PyPI would be awesome 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants