Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use pyproject.toml instead of setup.py, and skip versioneer #169

Merged
merged 29 commits into from
Nov 21, 2024

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Nov 20, 2024

This PR started out solving a deprecation warning when installing with pip:

  DEPRECATION: Legacy editable install of pyorbital==1.8.3+29.g19f444b from file:///home/a000680/usr/src/forks/pyorbital (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457

It ended up switching to pyproject.toml, ditching versioneer.py and by using more strict style checkers with ruff many small issues needed attention.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes flake8 pyorbital
  • Fully documented

Adam.Dybbroe added 4 commits November 21, 2024 13:10
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 91.81034% with 38 lines in your changes missing coverage. Please review.

Project coverage is 87.94%. Comparing base (eb37c5a) to head (e27a1d4).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
pyorbital/orbital.py 84.26% 14 Missing ⚠️
pyorbital/fetch_tles.py 0.00% 9 Missing ⚠️
pyorbital/tlefile.py 85.41% 7 Missing ⚠️
pyorbital/geoloc_example.py 0.00% 6 Missing ⚠️
pyorbital/check_platform.py 0.00% 1 Missing ⚠️
pyorbital/tests/test_tlefile.py 99.46% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   88.12%   87.94%   -0.18%     
==========================================
  Files          14       16       +2     
  Lines        2265     2306      +41     
==========================================
+ Hits         1996     2028      +32     
- Misses        269      278       +9     
Flag Coverage Δ
unittests 87.94% <91.81%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coveralls
Copy link

coveralls commented Nov 21, 2024

Coverage Status

coverage: 87.904% (-0.2%) from 88.06%
when pulling e27a1d4 on adybbroe:switch-to-pyproject-toml
into 19f444b on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Nov 21, 2024

As discussed the one remaining ruff error was a complexity issue with pyorbital/orbital.py:_SGDP4.__init__. I've added an ignore on that method to get ruff to pass. Dealing with the complexity of that method will take a considerable amount of work. My understanding is @pnuu might tackle it if he's foolish enough.

@pnuu
Copy link
Member

pnuu commented Nov 21, 2024

I'm actually already browsing through _SGDP4.__init__. If I have a moment tomorrow I'll have a go at it.

@djhoese djhoese merged commit 9700076 into pytroll:main Nov 21, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants