fix: withLookup in QueryGroupsAsync() #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Sep 12, 2024
| @@ -2361,6 +2361,8 @@ public async Task<UpdateResult> CreatePayloadIndexAsync( | |||
| PayloadSchemaType.Bool => FieldType.Bool, | |||
| PayloadSchemaType.Geo => FieldType.Geo, | |||
| PayloadSchemaType.Text => FieldType.Text, | |||
| PayloadSchemaType.Datetime => FieldType.Datetime, | |||
| PayloadSchemaType.Uuid => FieldType.Uuid, | |||
There was a problem hiding this comment.
Not related to this PR, but a structural unit test would be good to assert that all PayloadSchemaType are handled, so that if a later version introduces a new one, the test will fail when the client is generated from the new version. Will open an issue to track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
withLookupparam to theQueryGroupsAsync()method.DatetimeandUuidindex types to the helper converter.This change will break for anyone who is passing all values by position to
QueryGroupsAsync(), but I believe the probability of this is very low. If necessary, we can add a new overload instead.