Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: withLookup in QueryGroupsAsync() #65

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: withLookup in QueryGroupsAsync() #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Qdrant.Client/QdrantClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,6 +2361,8 @@ public async Task<UpdateResult> CreatePayloadIndexAsync(
PayloadSchemaType.Bool => FieldType.Bool,
PayloadSchemaType.Geo => FieldType.Geo,
PayloadSchemaType.Text => FieldType.Text,
PayloadSchemaType.Datetime => FieldType.Datetime,
PayloadSchemaType.Uuid => FieldType.Uuid,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but a structural unit test would be good to assert that all PayloadSchemaType are handled, so that if a later version introduces a new one, the test will fail when the client is generated from the new version. Will open an issue to track.


_ => throw new ArgumentException("Invalid PayloadSchemaType: " + schemaType, nameof(schemaType))
}
Expand Down Expand Up @@ -3949,6 +3951,7 @@ public async Task<IReadOnlyList<BatchResult>> QueryBatchAsync(
/// <param name="vectorsSelector">Options for specifying which vectors to include into the response.</param>
/// <param name="readConsistency">Options for specifying read consistency guarantees.</param>
/// <param name="shardKeySelector">Specify in which shards to look for the points, if not specified - look in all shards.</param>
/// <param name="withLookup">Options for specifying how to use the group id to lookup points in another collection.</param>
/// <param name="lookupFrom">The location to use for IDs lookup, if not specified - use the current collection and the 'usingVector' vector</param>
/// <param name="timeout">If set, overrides global timeout setting for this request.</param>
/// <param name="cancellationToken">The token to monitor for cancellation requests. The default value is <see cref="CancellationToken.None" />.</param>
Expand All @@ -3967,6 +3970,7 @@ public async Task<IReadOnlyList<PointGroup>> QueryGroupsAsync(
WithVectorsSelector? vectorsSelector = null,
ReadConsistency? readConsistency = null,
ShardKeySelector? shardKeySelector = null,
WithLookup? withLookup = null,
LookupLocation? lookupFrom = null,
TimeSpan? timeout = null,
CancellationToken cancellationToken = default)
Expand Down Expand Up @@ -4005,6 +4009,9 @@ public async Task<IReadOnlyList<PointGroup>> QueryGroupsAsync(
if (shardKeySelector is not null)
request.ShardKeySelector = shardKeySelector;

if (withLookup is not null)
request.WithLookup = withLookup;

if (lookupFrom is not null)
request.LookupFrom = lookupFrom;

Expand Down