Refactor QgsPointCloudIndex #59564
Merged
Refactor QgsPointCloudIndex #59564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
wonder-sk
reviewed
Nov 24, 2024
dvdkon
force-pushed
the
point-cloud-index-refactor
branch
2 times, most recently
from
9857af2 to
2d3f664
Compare
dvdkon
force-pushed
the
point-cloud-index-refactor
branch
2 times, most recently
from
8eb8eed to
7787202
Compare
nyalldawson
reviewed
Nov 29, 2024
| @@ -170,80 +170,6 @@ Only providers which report the CreateRenderer capability will return a 2D rende | |||
| providers will return ``None``. | |||
| %End | |||
|
|
|||
| virtual bool hasStatisticsMetadata() const; | |||
There was a problem hiding this comment.
This is all an API break -- we need to keep all methods exposed to Python for the lifetime of 3.x
There was a problem hiding this comment.
@nyalldawson QgsPointCloudDataProvider has been intentionally marked in docstring as experimental, allowing changes at in future - so I believe we should allow API breaks here...
|
@dvdkon can you update your branch please? There are some conflicts now... |
- Rename IndexedPointCloudNode to QgsPointCloudNodeId. - Introduce QgsPointCloudNode and move methods to it from QgsPointCloudIndex. - Report point cloud node bounds directly in CRS coordinates, without extra scaling and offset.
dvdkon
force-pushed
the
point-cloud-index-refactor
branch
from
dbe9221 to
44d5399
Compare
wonder-sk
reviewed
Dec 2, 2024
wonder-sk
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
QgsPointCloudIndex, removing some unnecessary complexity and improving its design to bring it more in line withQgsTiledSceneIndex.metadataStatistic()) have been removed. Now the only way to get statistics is throughmetadataStatistics()and theQgsPointCloudStatisticsobject.IndexedPointCloudNodeis renamed toQgsPointCloudNodeId.QgsPointCloudNode, along with a method on the index to get this object from an ID.Funded by: QGIS.org grant