-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename security.adoc to security-policy.adoc #1665
Conversation
@maxandersen @sberyozkin PTAL |
8eb68fd
to
38cd4bf
Compare
@gsmet Please review and merge. |
6fab40c
to
9e35e19
Compare
@gsmet Updated and ready to merge. |
Hi @gsmet Can you please look at this PR ? |
/assign @gsmet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not sure this change will change anything for Google searchability of the security guide... and it's breaking any external link to our security page which is a no-no.
We at the minimum need to put a redirect in place.
But even so, I'm not especially excited about it.
@maxandersen @insectengine WDYT?
f080a62
to
dba2ca6
Compare
Thanks. I've just added |
🙈 The PR is closed and the preview is expired. |
I've read but still I don't grok why changing this url is supposed to help? It is a good thing it's just quarkus.io/security. Why require the longer harder to remember/copy/read quarkus.io/security-policy url? |
Changing the title I can buy or at least add security policy in top part of message but the url and redirect is a -1 from me. |
An SEO best practice is to align the file name and the title of the document. |
thats fine but lets please not use long winded "policy" names in URLs. URLs like these are to be remembered, typed and understood easily. quarkus.io/security is easy to remember, easy to type and most understand that page has stuff to do around quarkus security - let me read that . quarkus.io/security-policy is not easy to remember, hard to type (is it with a or without a dash ? is it policy to not policy?, _ and if I see security-policy it is not a page I or many I can think of will go read :)z and in addition quarkus.io/security is short and descriptive and use same keywords as in title and in page so I think we are covered. |
Piling in here ... Based on my highly representative sample of one, I can confirm what Max says. A page named http://quarkus.io/security-policy is one I'd actively try to avoid reading. 😂 |
Absolutely, I'm happy we've discussed this and come to a consensus. My aim was to put into action what I thought Sergey was suggesting. As it stands, we've only agreed on revising the title. So, I'll remove the changes for the redirect, altering the file name, and updating the links. The PR should be ready to merge shortly. |
dba2ca6
to
fe6fd3a
Compare
I'll make a parallel change to https://github.com/quarkusio/quarkus/blob/master/SECURITY.md as well. |
@maxandersen @holly-cummins: Based on your feedback, I've retitled the security policy page to "Security policy" and removed everything else. Please approve so we can get this merged. |
|
@gsmet The result of our conversations is a simple change to the title. I believe this is ready to merge now. |
Fixes: #1664