Use the heartbeats shipped with the digest for cluster membership and failure detection #312
fulmicotonci.yml
on: pull_request
Check (fmt, dependency check, clippy, test)
1m 24s
Annotations
5 errors and 2 warnings
|
length comparison to zero:
chitchat/src/state.rs#L320
error: length comparison to zero
--> chitchat/src/state.rs:320:12
|
320 | if delta.nodes_to_reset.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!delta.nodes_to_reset.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `-D clippy::len-zero` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::len_zero)]`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
chitchat/src/failure_detector.rs#L61
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/failure_detector.rs:61:46
|
61 | if !self.dead_nodes.contains_key(&chitchat_id) {
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
|
length comparison to zero:
chitchat/src/state.rs#L320
error: length comparison to zero
--> chitchat/src/state.rs:320:12
|
320 | if delta.nodes_to_reset.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!delta.nodes_to_reset.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `-D clippy::len-zero` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::len_zero)]`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
chitchat/src/failure_detector.rs#L61
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/failure_detector.rs:61:46
|
61 | if !self.dead_nodes.contains_key(&chitchat_id) {
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
|
Check (fmt, dependency check, clippy, test)
Clippy had exited with the 101 exit code
|
|
Check (fmt, dependency check, clippy, test)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Check (fmt, dependency check, clippy, test)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|