Use the heartbeats shipped with the digest for cluster membership and failure detection #312
clippy
4 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 4 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check failure on line 320 in chitchat/src/state.rs
github-actions / clippy
length comparison to zero
error: length comparison to zero
--> chitchat/src/state.rs:320:12
|
320 | if delta.nodes_to_reset.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!delta.nodes_to_reset.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `-D clippy::len-zero` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::len_zero)]`
Check failure on line 61 in chitchat/src/failure_detector.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/failure_detector.rs:61:46
|
61 | if !self.dead_nodes.contains_key(&chitchat_id) {
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 320 in chitchat/src/state.rs
github-actions / clippy
length comparison to zero
error: length comparison to zero
--> chitchat/src/state.rs:320:12
|
320 | if delta.nodes_to_reset.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!delta.nodes_to_reset.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `-D clippy::len-zero` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::len_zero)]`
Check failure on line 61 in chitchat/src/failure_detector.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/failure_detector.rs:61:46
|
61 | if !self.dead_nodes.contains_key(&chitchat_id) {
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`