Delta validation #130
Merged
Delta validation #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
6 times, most recently
from
786bf89 to
2d9549e
Compare
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
4 times, most recently
from
4f64387 to
3cfc3e3
Compare
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
3cfc3e3 to
bdcd8c6
Compare
Due to the nature UDP, the existence of resets and the fact that we are gossipping to several nodes at the same time, it is possible for our obsolete deltas to arrive. This PR adds some validation to detect if the delta is valid, and whether it will bring us to a better state or not. It also removes the nodes to reset information, which was actually taking a large amount of the MTU on large clusters. (For 20 nodes, around 1KB) Reset is now just expressed by sending the delta with `from_version = 0`. Closes #129 - Removing hidden contract We avoid computing tombstone's Instant upon deserialization. It was hiding a very hidden contract forcing us to deserialize mutation in the order of their version. With this change, we defer the computation of the instant to the call of the apply_delta method. All of the tombstone from a delta get the exact same `Instant`.
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
37c0ccf to
c55c883
Compare
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
321a2de to
094d986
Compare
Co-authored-by: Raphaël Marinier <[email protected]>
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
565d538 to
6c77259
Compare
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
2 times, most recently
from
9d376e6 to
4d2a9b3
Compare
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
4d2a9b3 to
65dfd8c
Compare
RaphaelMarinier
approved these changes
Mar 7, 2024
Co-authored-by: Raphaël Marinier <[email protected]>
fulmicoton
force-pushed
the
issue/128-delta-validation
branch
from
e6b51f4 to
5b64937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: validation of delta before applying them.
Closes #129