Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tantivy #5093

Merged
merged 3 commits into from
Jun 10, 2024
Merged

update tantivy #5093

merged 3 commits into from
Jun 10, 2024

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Jun 7, 2024

Description

fix #5089
fix #5041

How was this PR tested?

ran unit tests

@trinity-1686a trinity-1686a requested a review from PSeitz June 7, 2024 13:39
@trinity-1686a
Copy link
Contributor Author

hum, previously the query parser would leave jour\* as is, but now it interpret the escape and returns jour*. It needs to only interpret escape sequence if the char after is one that required escaping

Copy link

github-actions bot commented Jun 7, 2024

On SSD:

Average search latency is 1.02x that of the reference (lower is better).
Ref run id: 1954, ref commit: c2a2674
Link

On GCS:

Average search latency is 1.04x that of the reference (lower is better).
Ref run id: 1955, ref commit: c2a2674
Link

Copy link
Contributor

@PSeitz PSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the failing test related to a query parser change?

@trinity-1686a
Copy link
Contributor Author

Is the failing test related to a query parser change?

it is, but that's fixed now

@trinity-1686a trinity-1686a merged commit 47caef0 into main Jun 10, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/update-tantivy branch June 10, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants