Add missing fields to ES compatible Query API #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [_source][1] schema * [docvalue][2] schema I've added additional fields as `serde_json::Value` to prevent complex struct definitions as we won't use them anyway. [1]: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/search-fields.html#source-filtering [2]: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-fields.html#docvalue-fields
According to [doc][1] multi_match has 6 modes. Best fields and Cross fields can be converted to Most fields as they close by logic and I couldn't find their implementations. BoolPrefix was implemented and I added it to the parser. Tests was extended to cover all cases, for that I changed a bit of structures and added missing traits implementations. [1]: https://opensearch.org/docs/latest/query-dsl/full-text/multi-match/#multi-match-query-types
fulmicoton
reviewed
Jun 12, 2024
| @@ -40,6 +40,8 @@ pub struct RangeQueryParams { | |||
| lte: Option<JsonLiteral>, | |||
| #[serde(default)] | |||
| boost: Option<NotNaNf32>, | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
Suggested change
| #[serde(default)] | |
| // Currently NO-OP (see #5098) | |
| #[serde(default)] |
|
@kuzaxak to make things smoother I merged and will commit my comments above that. Next time, could you create a feature branch on the quickwit repo (I think you have the permissions to do that) |
|
For info: #5111 |
@fulmicoton |
|
I mean pushing a branch on quickwit-oss/quickwit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added additional fields as
serde_json::Valueto prevent complex struct definitions as we won't use them anyway.Addressing #5097
How was this PR tested?
I've tested it locally using queries taken from OSD
Additionally I've added some tests for multi_match parser code.