run coverage only after merge #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverage is a quite slow step in CI. It can be run only after merging
fulmicoton
reviewed
Oct 12, 2023
fulmicoton
reviewed
Oct 12, 2023
| run: cargo +nightly build --all-features | ||
|
|
||
| - name: Check Bench Compilation | ||
| run: cargo +nightly bench --no-run --profile=dev --all-features |
There was a problem hiding this comment.
Will we look at the result? It won't give a diff of the last run will it?
It seems too much for a PR especially.
There was a problem hiding this comment.
Note the --no-run argument. This will not execute the benchmarks, just check that they compile (and even use the dev profile to get fast build time instead of fast builds).
There was a problem hiding this comment.
We broke the benchmarks compilation previously, since they are not covered in the CI. This did break as a consequence https://pseitz.github.io/tantivy_bench_graph/index.html
Co-authored-by: Paul Masurel <[email protected]>
fulmicoton
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverage is a quite slow step in CI. It can be run only after merging
Add compile benchmarks to regular CI test