Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run coverage only after merge #2212

Merged
merged 2 commits into from
Oct 18, 2023
Merged

run coverage only after merge #2212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7d6389
run coverage only after merge
PSeitz Oct 6, 2023
c588b1d
Apply suggestions from code review
PSeitz Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: Coverage
on:
push:
branches: [main]
pull_request:
branches: [main]

# Ensures that we cancel running jobs for the same PR / same workflow.
concurrency:
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ jobs:

- name: Check Formatting
run: cargo +nightly fmt --all -- --check

- name: Check Stable Compilation
run: cargo build --all-features

- name: Check Nightly Compilation
run: cargo +nightly build --all-features
PSeitz marked this conversation as resolved.
Show resolved Hide resolved

- name: Check Bench Compilation
run: cargo +nightly bench --no-run --profile=dev --all-features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we look at the result? It won't give a diff of the last run will it?
It seems too much for a PR especially.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the --no-run argument. This will not execute the benchmarks, just check that they compile (and even use the dev profile to get fast build time instead of fast builds).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We broke the benchmarks compilation previously, since they are not covered in the CI. This did break as a consequence https://pseitz.github.io/tantivy_bench_graph/index.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it!


- uses: actions-rs/clippy-check@v1
with:
Expand Down