Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Declarative config #85

Merged
merged 5 commits into from
Dec 11, 2024
Merged

BLD: Declarative config #85

merged 5 commits into from
Dec 11, 2024
+84 −120

Conversation

sabonerune
Copy link
Contributor

Move most of the configuration from setup.py to pyproject.toml.

@sabonerune
BLD: Declarative config
c362dae 
Move most of the configuration from setup.py to pyproject.toml.
sabonerune
sabonerune commented Oct 21, 2024
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
release.sh Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@sabonerune sabonerune marked this pull request as ready for review October 21, 2024 10:21
r9y9
r9y9 reviewed Dec 10, 2024
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix! and sorry again I was too unresponsive these days. Please check a few my comments and I'll merge this PR soon

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
sabonerune and others added 4 commits December 11, 2024 18:59
@sabonerune
Update pyproject.toml
5f07318 
Drop py37.
@sabonerune @r9y9
Update pyproject.toml
341b337 
Drop py37.

Co-authored-by: Ryuichi Yamamoto <[email protected]>
@sabonerune
Update pyproject.toml
dfb2451 
Drop py37.
@sabonerune
Update pyproject.toml
a8140bf 
Drop py37.
@sabonerune sabonerune requested a review from r9y9 December 11, 2024 10:34
r9y9
r9y9 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@r9y9 r9y9 merged commit 3a91d16 into r9y9:master Dec 11, 2024
6 checks passed
@sabonerune sabonerune deleted the bld/declarative-config branch December 11, 2024 11:45
sabonerune added a commit to sabonerune/pyopenjtalk that referenced this pull request Dec 19, 2024
@sabonerune
FIX: Fix setuptools warning.
acfb7c0 
I made a mistake with PR r9y9#85.
@sabonerune sabonerune mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r9y9 r9y9 r9y9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabonerune @r9y9