FIX: Fix setuptools warning. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a mistake with PR r9y9#85.
sabonerune
commented
Dec 19, 2024
| recursive-include lib *.cpp *.c *.h README LICENSE COPYING CMakeLists.txt *.in | ||
| recursive-include lib *.cpp *.c *.h README COPYING CMakeLists.txt *.in |
There was a problem hiding this comment.
Get the warning: warning: no files found matching 'LICENSE' under directory 'lib'.
This is because there is no file called LICENSE in the lib directory.
Comment on lines
-70
to
+71
| [tool.setuptools.packages] | ||
| find.namespaces = false | ||
| [tool.setuptools.packages.find] | ||
| include = ["pyopenjtalk*"] |
There was a problem hiding this comment.
Get the warning: Package would be ignored.
The cause is that you set namespaces = false.
pyoenjtalk/htsvoice should have been a namespace package.
https://setuptools.pypa.io/en/latest/userguide/datafiles.html#subdirectory-for-data-files
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake with PR #85.