Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix setuptools warning. #90

Merged
merged 1 commit into from
Dec 25, 2024
Merged

FIX: Fix setuptools warning. #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ include pyopenjtalk/version.py
exclude .gitignore .gitmodules .travis.yml release.sh tox.ini
prune .github/*
prune docs/**
recursive-include lib *.cpp *.c *.h README LICENSE COPYING CMakeLists.txt *.in
recursive-include lib *.cpp *.c *.h README COPYING CMakeLists.txt *.in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the warning: warning: no files found matching 'LICENSE' under directory 'lib'.
This is because there is no file called LICENSE in the lib directory.

exclude lib/open_jtalk/src/mecab/src/config.h
prune lib/open_jtalk/src/build/**
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ dev = [
test = ["pytest", "scipy"]
marine = ["marine>=0.0.5"]

[tool.setuptools.packages]
find.namespaces = false
[tool.setuptools.packages.find]
include = ["pyopenjtalk*"]
Comment on lines -70 to +71
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the warning: Package would be ignored.
The cause is that you set namespaces = false.

pyoenjtalk/htsvoice should have been a namespace package.
https://setuptools.pypa.io/en/latest/userguide/datafiles.html#subdirectory-for-data-files
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages


[tool.setuptools.exclude-package-data]
"*" = ["*.pyx", "*.pxd"]
Expand Down
Loading