Remove unused code in glyph drawing code #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original intent of the `when` block was to remove the line around the glyph when the line and fill color were the same. However, the `eq?` test was always false in Typed Racket, so the code never executed. The `eq?` test is now fixed in racket/typed-racket#1358, but as a result, the visual layout of plots would change, making glyphs smaller, since the outline is not drawn anymore. To keep the backwards compatibility of the plot look-and-feel, the entire `when` block was removed.
|
@sorawee FYI |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
|
Interestingly, DrDr has still been failing, even after this PR. http://drdr.racket-lang.org/65790/ @samth do you know what's going on? |
|
@sorawee is there a way in DrDr to get access to the build artifacts? I downloaded the archive (trunk.tgz), but that seems to only contain the source code being built... It would be good to compare the draw steps on the built to determine what failed. |
|
I believe that it was just the pkg server not updating; it looks fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of the
whenblock was to remove the line around the glyph when the line and fill color were the same. However, theeq?test was always false in Typed Racket, so the code never executed.The
eq?test is now fixed inracket/typed-racket#1358, but as a result, the visual layout of plots would change, making glyphs smaller, since the outline is not drawn anymore.
To keep the backwards compatibility of the plot look-and-feel, the entire
whenblock was removed.